Closed Bug 671261 Opened 14 years ago Closed 14 years ago

Dehydra: remove support of local gcc in configure script

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #545656 - Flags: review?(tglek)
Whiteboard: [needs review]
Attached patch Patch v1.1 (obsolete) — Splinter Review
Updates the help message.
Attachment #545656 - Attachment is obsolete: true
Attachment #545657 - Flags: review?(tglek)
Attachment #545656 - Flags: review?(tglek)
Comment on attachment 545657 [details] [diff] [review] Patch v1.1 Thanks, but this needs to go further. --gcc-build should probably become --gcc. --gcc-src= should be removed
Attachment #545657 - Flags: review?(tglek) → review-
(In reply to comment #2) > Comment on attachment 545657 [details] [diff] [review] [review] > Patch v1.1 > > Thanks, but this needs to go further. > > --gcc-build should probably become --gcc. --gcc-src= should be removed Why not remove the --gcc* options altogether, and use CC/CXX and fallback to cc/c++ when the environment variables aren't set, like most anything else?
It also shouldn't be necessary to put the full path in CC/CXX...
Agreed with above
Attached patch Patch v2Splinter Review
Now, a specific g++ can be specified with CXX env variable. Otherwise, g++ is going to be used, except on MacOS X where g++-4.2 will be used. I'm not using dehydra on a Mac so I prefer to not change that. Let me know if I should.
Attachment #545657 - Attachment is obsolete: true
Attachment #545937 - Flags: review?(tglek)
(In reply to comment #6) > Created attachment 545937 [details] [diff] [review] [review] > Patch v2 > > Now, a specific g++ can be specified with CXX env variable. Otherwise, g++ > is going to be used, except on MacOS X where g++-4.2 will be used. I'm not > using dehydra on a Mac so I prefer to not change that. Let me know if I > should. Actually, I wonder, Apple's gcc supports plugins?
Comment on attachment 545937 [details] [diff] [review] Patch v2 This looks ok
Attachment #545937 - Flags: review?(tglek) → review+
(In reply to comment #7) > > Actually, I wonder, Apple's gcc supports plugins? mac support is dead.
(In reply to comment #9) > (In reply to comment #7) > > > > > Actually, I wonder, Apple's gcc supports plugins? > > mac support is dead. Then I could just remove these lines, right?
(In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #7) > > > > > > > > Actually, I wonder, Apple's gcc supports plugins? > > > > mac support is dead. > > Then I could just remove these lines, right? sure
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Summary: Dehydra: don't check for a local gcc given that using patched gcc is no longer supported → Dehydra: remove support of local gcc in configure script
Whiteboard: [needs review]
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: