Closed
Bug 671261
Opened 13 years ago
Closed 13 years ago
Dehydra: remove support of local gcc in configure script
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mounir, Assigned: mounir)
Details
Attachments
(1 file, 2 obsolete files)
7.17 KB,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #545656 -
Flags: review?(tglek)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs review]
Assignee | ||
Comment 1•13 years ago
|
||
Updates the help message.
Attachment #545656 -
Attachment is obsolete: true
Attachment #545657 -
Flags: review?(tglek)
Attachment #545656 -
Flags: review?(tglek)
Comment 2•13 years ago
|
||
Comment on attachment 545657 [details] [diff] [review] Patch v1.1 Thanks, but this needs to go further. --gcc-build should probably become --gcc. --gcc-src= should be removed
Attachment #545657 -
Flags: review?(tglek) → review-
Comment 3•13 years ago
|
||
(In reply to comment #2) > Comment on attachment 545657 [details] [diff] [review] [review] > Patch v1.1 > > Thanks, but this needs to go further. > > --gcc-build should probably become --gcc. --gcc-src= should be removed Why not remove the --gcc* options altogether, and use CC/CXX and fallback to cc/c++ when the environment variables aren't set, like most anything else?
Comment 4•13 years ago
|
||
It also shouldn't be necessary to put the full path in CC/CXX...
Comment 5•13 years ago
|
||
Agreed with above
Assignee | ||
Comment 6•13 years ago
|
||
Now, a specific g++ can be specified with CXX env variable. Otherwise, g++ is going to be used, except on MacOS X where g++-4.2 will be used. I'm not using dehydra on a Mac so I prefer to not change that. Let me know if I should.
Attachment #545657 -
Attachment is obsolete: true
Attachment #545937 -
Flags: review?(tglek)
Assignee | ||
Comment 7•13 years ago
|
||
(In reply to comment #6) > Created attachment 545937 [details] [diff] [review] [review] > Patch v2 > > Now, a specific g++ can be specified with CXX env variable. Otherwise, g++ > is going to be used, except on MacOS X where g++-4.2 will be used. I'm not > using dehydra on a Mac so I prefer to not change that. Let me know if I > should. Actually, I wonder, Apple's gcc supports plugins?
Comment 8•13 years ago
|
||
Comment on attachment 545937 [details] [diff] [review] Patch v2 This looks ok
Attachment #545937 -
Flags: review?(tglek) → review+
Comment 9•13 years ago
|
||
(In reply to comment #7) > > Actually, I wonder, Apple's gcc supports plugins? mac support is dead.
Assignee | ||
Comment 10•13 years ago
|
||
(In reply to comment #9) > (In reply to comment #7) > > > > > Actually, I wonder, Apple's gcc supports plugins? > > mac support is dead. Then I could just remove these lines, right?
Comment 11•13 years ago
|
||
(In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #7) > > > > > > > > Actually, I wonder, Apple's gcc supports plugins? > > > > mac support is dead. > > Then I could just remove these lines, right? sure
Assignee | ||
Comment 12•13 years ago
|
||
Pushed: https://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/468f253e4ae7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: Dehydra: don't check for a local gcc given that using patched gcc is no longer supported → Dehydra: remove support of local gcc in configure script
Whiteboard: [needs review]
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•