The default bug view has changed. See this FAQ.

Dehydra: remove support of local gcc in configure script

RESOLVED FIXED

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 545656 [details] [diff] [review]
Patch v1
Attachment #545656 - Flags: review?(tglek)
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
(Assignee)

Comment 1

6 years ago
Created attachment 545657 [details] [diff] [review]
Patch v1.1

Updates the help message.
Attachment #545656 - Attachment is obsolete: true
Attachment #545657 - Flags: review?(tglek)
Attachment #545656 - Flags: review?(tglek)

Comment 2

6 years ago
Comment on attachment 545657 [details] [diff] [review]
Patch v1.1

Thanks, but this needs to go further.

--gcc-build should probably become --gcc. --gcc-src= should be removed
Attachment #545657 - Flags: review?(tglek) → review-
(In reply to comment #2)
> Comment on attachment 545657 [details] [diff] [review] [review]
> Patch v1.1
> 
> Thanks, but this needs to go further.
> 
> --gcc-build should probably become --gcc. --gcc-src= should be removed

Why not remove the --gcc* options altogether, and use CC/CXX and fallback to cc/c++ when the environment variables aren't set, like most anything else?
It also shouldn't be necessary to put the full path in CC/CXX...

Comment 5

6 years ago
Agreed with above
(Assignee)

Comment 6

6 years ago
Created attachment 545937 [details] [diff] [review]
Patch v2

Now, a specific g++ can be specified with CXX env variable. Otherwise, g++ is going to be used, except on MacOS X where g++-4.2 will be used. I'm not using dehydra on a Mac so I prefer to not change that. Let me know if I should.
Attachment #545657 - Attachment is obsolete: true
Attachment #545937 - Flags: review?(tglek)
(Assignee)

Comment 7

6 years ago
(In reply to comment #6)
> Created attachment 545937 [details] [diff] [review] [review]
> Patch v2
> 
> Now, a specific g++ can be specified with CXX env variable. Otherwise, g++
> is going to be used, except on MacOS X where g++-4.2 will be used. I'm not
> using dehydra on a Mac so I prefer to not change that. Let me know if I
> should.

Actually, I wonder, Apple's gcc supports plugins?

Comment 8

6 years ago
Comment on attachment 545937 [details] [diff] [review]
Patch v2

This looks ok
Attachment #545937 - Flags: review?(tglek) → review+

Comment 9

6 years ago
(In reply to comment #7)

> 
> Actually, I wonder, Apple's gcc supports plugins?

mac support is dead.
(Assignee)

Comment 10

6 years ago
(In reply to comment #9)
> (In reply to comment #7)
> 
> > 
> > Actually, I wonder, Apple's gcc supports plugins?
> 
> mac support is dead.

Then I could just remove these lines, right?

Comment 11

6 years ago
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #7)
> > 
> > > 
> > > Actually, I wonder, Apple's gcc supports plugins?
> > 
> > mac support is dead.
> 
> Then I could just remove these lines, right?

sure
(Assignee)

Comment 12

6 years ago
Pushed:
https://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/468f253e4ae7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Summary: Dehydra: don't check for a local gcc given that using patched gcc is no longer supported → Dehydra: remove support of local gcc in configure script
Whiteboard: [needs review]
You need to log in before you can comment on or make changes to this bug.