Last Comment Bug 671261 - Dehydra: remove support of local gcc in configure script
: Dehydra: remove support of local gcc in configure script
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Rewriting and Analysis (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-13 06:55 PDT by Mounir Lamouri (:mounir)
Modified: 2011-07-14 10:03 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (983 bytes, patch)
2011-07-13 06:55 PDT, Mounir Lamouri (:mounir)
no flags Details | Diff | Splinter Review
Patch v1.1 (1.72 KB, patch)
2011-07-13 07:00 PDT, Mounir Lamouri (:mounir)
taras.mozilla: review-
Details | Diff | Splinter Review
Patch v2 (7.17 KB, patch)
2011-07-14 09:46 PDT, Mounir Lamouri (:mounir)
taras.mozilla: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-07-13 06:55:44 PDT
Created attachment 545656 [details] [diff] [review]
Patch v1
Comment 1 Mounir Lamouri (:mounir) 2011-07-13 07:00:26 PDT
Created attachment 545657 [details] [diff] [review]
Patch v1.1

Updates the help message.
Comment 2 (dormant account) 2011-07-13 09:32:07 PDT
Comment on attachment 545657 [details] [diff] [review]
Patch v1.1

Thanks, but this needs to go further.

--gcc-build should probably become --gcc. --gcc-src= should be removed
Comment 3 Mike Hommey [:glandium] 2011-07-13 09:53:00 PDT
(In reply to comment #2)
> Comment on attachment 545657 [details] [diff] [review] [review]
> Patch v1.1
> 
> Thanks, but this needs to go further.
> 
> --gcc-build should probably become --gcc. --gcc-src= should be removed

Why not remove the --gcc* options altogether, and use CC/CXX and fallback to cc/c++ when the environment variables aren't set, like most anything else?
Comment 4 Joshua Cranmer [:jcranmer] 2011-07-13 09:55:55 PDT
It also shouldn't be necessary to put the full path in CC/CXX...
Comment 5 (dormant account) 2011-07-13 10:11:33 PDT
Agreed with above
Comment 6 Mounir Lamouri (:mounir) 2011-07-14 09:46:39 PDT
Created attachment 545937 [details] [diff] [review]
Patch v2

Now, a specific g++ can be specified with CXX env variable. Otherwise, g++ is going to be used, except on MacOS X where g++-4.2 will be used. I'm not using dehydra on a Mac so I prefer to not change that. Let me know if I should.
Comment 7 Mounir Lamouri (:mounir) 2011-07-14 09:47:39 PDT
(In reply to comment #6)
> Created attachment 545937 [details] [diff] [review] [review]
> Patch v2
> 
> Now, a specific g++ can be specified with CXX env variable. Otherwise, g++
> is going to be used, except on MacOS X where g++-4.2 will be used. I'm not
> using dehydra on a Mac so I prefer to not change that. Let me know if I
> should.

Actually, I wonder, Apple's gcc supports plugins?
Comment 8 (dormant account) 2011-07-14 09:50:12 PDT
Comment on attachment 545937 [details] [diff] [review]
Patch v2

This looks ok
Comment 9 (dormant account) 2011-07-14 09:51:01 PDT
(In reply to comment #7)

> 
> Actually, I wonder, Apple's gcc supports plugins?

mac support is dead.
Comment 10 Mounir Lamouri (:mounir) 2011-07-14 09:51:48 PDT
(In reply to comment #9)
> (In reply to comment #7)
> 
> > 
> > Actually, I wonder, Apple's gcc supports plugins?
> 
> mac support is dead.

Then I could just remove these lines, right?
Comment 11 (dormant account) 2011-07-14 09:58:45 PDT
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #7)
> > 
> > > 
> > > Actually, I wonder, Apple's gcc supports plugins?
> > 
> > mac support is dead.
> 
> Then I could just remove these lines, right?

sure
Comment 12 Mounir Lamouri (:mounir) 2011-07-14 10:03:08 PDT
Pushed:
https://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/468f253e4ae7

Note You need to log in before you can comment on or make changes to this bug.