GCC 4.6 build warning: nsSMILParserUtils.cpp:317:20: warning: variable ‘start’ set but not used [-Wunused-but-set-variable]

RESOLVED FIXED in mozilla8

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

Filing bug on this GCC 4.6 build warning:
{
nsSMILParserUtils.cpp:317:20: warning: variable ‘start’ set but not used [-Wunused-but-set-variab
}

Looks like this has been the case since that chunk of code was added, in Bug 474743:
http://hg.mozilla.org/mozilla-central/diff/192adf25beb3/content/smil/nsSMILParserUtils.cpp#l1.194
but we didn't have a compiler that warned us about it until recently. :)
Created attachment 545704 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #545704 - Flags: review?(birtles)
Attachment #545704 - Flags: review?(birtles) → review+

Comment 2

6 years ago
You could combine declaration and assignment here.
Thanks, good point.  I made that tweak before landing.
  http://hg.mozilla.org/integration/mozilla-inbound/rev/61f0230a4a28
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning] → [build_warning][inbound]
http://hg.mozilla.org/mozilla-central/rev/61f0230a4a28
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][inbound] → [build_warning]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.