Closed
Bug 671341
Opened 13 years ago
Closed 13 years ago
GCC 4.6 build warning: nsSMILParserUtils.cpp:317:20: warning: variable ‘start’ set but not used [-Wunused-but-set-variable]
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
967 bytes,
patch
|
birtles
:
review+
|
Details | Diff | Splinter Review |
Filing bug on this GCC 4.6 build warning:
{
nsSMILParserUtils.cpp:317:20: warning: variable ‘start’ set but not used [-Wunused-but-set-variab
}
Looks like this has been the case since that chunk of code was added, in Bug 474743:
http://hg.mozilla.org/mozilla-central/diff/192adf25beb3/content/smil/nsSMILParserUtils.cpp#l1.194
but we didn't have a compiler that warned us about it until recently. :)
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Updated•13 years ago
|
Attachment #545704 -
Flags: review?(birtles) → review+
|
||
Comment 2•13 years ago
|
||
You could combine declaration and assignment here.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Thanks, good point. I made that tweak before landing. http://hg.mozilla.org/integration/mozilla-inbound/rev/61f0230a4a28
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning] → [build_warning][inbound]
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/61f0230a4a28
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][inbound] → [build_warning]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•