Closed
Bug 671438
Opened 14 years ago
Closed 14 years ago
nsOggCodecState::PacketOutUntilGranulepos() doesn't propagate unrecoverable errors
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
4.66 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
Michael Wu pointed this out in Bug 671185. nsOggCodecState::PacketOutUntilGranulepos() is returning NS_ERROR_FAILURE when ogg_stream_check() fails, but PacketOutUntilGranulepos() is supposed to return PR_Bool. We can't just return PR_FALSE, as that won't propagate the unrecoverableness of the error. The other place we call ogg_stream_check() we're correctly propagating unrecoverableness.
|
Assignee | |
Comment 1•14 years ago
|
||
Propagate errors from ogg_stream_check() in nsOggCodecState::PacketOutUntilGranulepos(). This will cause the stream to end if the ogg_stream_state encounters an unrecoverable error (all future operations on the stream will be no-ops anyway).
|
||
Comment 2•14 years ago
|
||
Comment on attachment 546241 [details] [diff] [review]
Patch
Review of attachment 546241 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #546241 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•