Last Comment Bug 671438 - nsOggCodecState::PacketOutUntilGranulepos() doesn't propagate unrecoverable errors
: nsOggCodecState::PacketOutUntilGranulepos() doesn't propagate unrecoverable e...
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla8
Assigned To: Chris Pearce (:cpearce)
: Maire Reavy [:mreavy] Please needinfo me
Depends on:
Blocks: 671185
  Show dependency treegraph
Reported: 2011-07-13 16:15 PDT by Chris Pearce (:cpearce)
Modified: 2011-07-19 08:11 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (4.66 KB, patch)
2011-07-15 15:20 PDT, Chris Pearce (:cpearce)
cajbir.bugzilla: review+
Details | Diff | Splinter Review

Description User image Chris Pearce (:cpearce) 2011-07-13 16:15:20 PDT
Michael Wu pointed this out in Bug 671185. nsOggCodecState::PacketOutUntilGranulepos() is returning NS_ERROR_FAILURE when ogg_stream_check() fails, but PacketOutUntilGranulepos() is supposed to return PR_Bool. We can't just return PR_FALSE, as that won't propagate the unrecoverableness of the error. The other place we call ogg_stream_check() we're correctly propagating unrecoverableness.
Comment 1 User image Chris Pearce (:cpearce) 2011-07-15 15:20:53 PDT
Created attachment 546241 [details] [diff] [review]

Propagate errors from ogg_stream_check() in nsOggCodecState::PacketOutUntilGranulepos(). This will cause the stream to end if the ogg_stream_state encounters an unrecoverable error (all future operations on the stream will be no-ops anyway).
Comment 2 User image cajbir (:cajbir) 2011-07-17 20:06:58 PDT
Comment on attachment 546241 [details] [diff] [review]

Review of attachment 546241 [details] [diff] [review]:
Comment 4 User image Marco Bonardo [::mak] 2011-07-19 08:11:47 PDT

Note You need to log in before you can comment on or make changes to this bug.