nsOggCodecState::PacketOutUntilGranulepos() doesn't propagate unrecoverable errors

RESOLVED FIXED in mozilla8

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Michael Wu pointed this out in Bug 671185. nsOggCodecState::PacketOutUntilGranulepos() is returning NS_ERROR_FAILURE when ogg_stream_check() fails, but PacketOutUntilGranulepos() is supposed to return PR_Bool. We can't just return PR_FALSE, as that won't propagate the unrecoverableness of the error. The other place we call ogg_stream_check() we're correctly propagating unrecoverableness.
(Assignee)

Comment 1

6 years ago
Created attachment 546241 [details] [diff] [review]
Patch

Propagate errors from ogg_stream_check() in nsOggCodecState::PacketOutUntilGranulepos(). This will cause the stream to end if the ogg_stream_state encounters an unrecoverable error (all future operations on the stream will be no-ops anyway).
Assignee: nobody → chris
Status: NEW → ASSIGNED
Attachment #546241 - Flags: review?(chris.double)

Comment 2

6 years ago
Comment on attachment 546241 [details] [diff] [review]
Patch

Review of attachment 546241 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #546241 - Flags: review?(chris.double) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/81dfee58c47f
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/81dfee58c47f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.