671439 - [Regression] Notifications does not appear on the corresponding tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Mozilla/5.0 (Android; Linux armv71; rv8.0a1) Gecko/20110712 Firefox/8.0a1 Fennec/8.0a1
Device: HTC Flyer
OS: Android 2.3

1. go to about:home
2. open a new tab and go to http://vingtetun.org/todo
3. go back to the first tab (about:home)

Expected: no offline notification appears
Actual: offline notification will appear

Regression bug 639985
Note:
1. also occurs on current beta release

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Not a toaster

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Fixes this prompt.

There are two others in /mobile that are going to take more work to fix. One involves the addon blocklist prompt:

mxr.mozilla.org/mozilla-central/source/mobile/components/BlocklistPrompt.js#58

(we don't have a window here yet). The other involves addon installs:

http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser.js#2406

In that case, desktop finds the window of the request, and then backs that out to find the browser. We don't have the window, so will need to look into alternatives.

There's also an instance in our PopupBlocker code, but it looks like we just skip the notification if the request isn't coming from the selected browser.

Comment 3

[Wesley Johnston (:wesj)]

inbound - http://hg.mozilla.org/integration/mozilla-inbound/rev/99ba817fef41

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/99ba817fef41

Comment 5

[Cristian Nicolae (:xti)]

This issue is not reproducible anymore on the latest Aurora build, if steps from comment #0 are performed.

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110901
Firefox/8.0a1 Fennec/8.0a1
Device: Samsung Galaxy S
OS: Android 2.2