Last Comment Bug 671441 - Detect whether the crtdll.obj hack is necessary
: Detect whether the crtdll.obj hack is necessary
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Memory Allocator (show other bugs)
: Trunk
: x86 Windows XP
: -- enhancement (vote)
: ---
Assigned To: neil@parkwaycc.co.uk
:
Mentors:
Depends on: 515492
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-13 16:44 PDT by neil@parkwaycc.co.uk
Modified: 2011-07-17 10:41 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Possible patch (1.66 KB, patch)
2011-07-13 16:49 PDT, neil@parkwaycc.co.uk
khuey: review+
Details | Diff | Splinter Review

Description neil@parkwaycc.co.uk 2011-07-13 16:44:42 PDT
As far as I can tell, my crtdll.obj from the Windows 7.1 SDK doesn't call __imp__free, so I should be able to link to msvc(p)rtd instead of mozcrt.
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-13 16:46:41 PDT
Yeah, we should do this in configure.
Comment 2 neil@parkwaycc.co.uk 2011-07-13 16:49:34 PDT
Created attachment 545781 [details] [diff] [review]
Possible patch

I considered removing the NO_INSTALL_IMPORT_LIBRARY = 1 from jemalloc's Makefile.in which would let me simplify the path to $(DIST)/lib/jemalloc.lib
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-14 08:59:06 PDT
Comment on attachment 545781 [details] [diff] [review]
Possible patch

Review of attachment 545781 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 4 neil@parkwaycc.co.uk 2011-07-17 03:20:23 PDT
Comment on attachment 545781 [details] [diff] [review]
Possible patch

>+      if grep -q '__imp__?free' crtdll.obj; then
Oops, this was supposed to be egrep, which supports ?s...
Comment 5 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-17 10:41:20 PDT
http://hg.mozilla.org/mozilla-central/rev/5dd42d33cba8

I changed it to use what I think is the right syntax.

Note You need to log in before you can comment on or make changes to this bug.