The default bug view has changed. See this FAQ.

Detect whether the crtdll.obj hack is necessary

RESOLVED FIXED

Status

()

Core
Memory Allocator
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
As far as I can tell, my crtdll.obj from the Windows 7.1 SDK doesn't call __imp__free, so I should be able to link to msvc(p)rtd instead of mozcrt.
Yeah, we should do this in configure.
(Assignee)

Comment 2

6 years ago
Created attachment 545781 [details] [diff] [review]
Possible patch

I considered removing the NO_INSTALL_IMPORT_LIBRARY = 1 from jemalloc's Makefile.in which would let me simplify the path to $(DIST)/lib/jemalloc.lib
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #545781 - Flags: review?(khuey)
Comment on attachment 545781 [details] [diff] [review]
Possible patch

Review of attachment 545781 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545781 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 545781 [details] [diff] [review]
Possible patch

>+      if grep -q '__imp__?free' crtdll.obj; then
Oops, this was supposed to be egrep, which supports ?s...
http://hg.mozilla.org/mozilla-central/rev/5dd42d33cba8

I changed it to use what I think is the right syntax.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.