671441 - Detect whether the crtdll.obj hack is necessary

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Description

[[e-mail]]

As far as I can tell, my crtdll.obj from the Windows 7.1 SDK doesn't call __imp__free, so I should be able to link to msvc(p)rtd instead of mozcrt.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, we should do this in configure.

Comment 2

[[e-mail]]

Attachment: Possible patch

I considered removing the NO_INSTALL_IMPORT_LIBRARY = 1 from jemalloc's Makefile.in which would let me simplify the path to $(DIST)/lib/jemalloc.lib

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 545781 [details] [diff] [review]
Possible patch

Review of attachment 545781 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[[e-mail]]

Comment on attachment 545781 [details] [diff] [review]
Possible patch

>+      if grep -q '__imp__?free' crtdll.obj; then
Oops, this was supposed to be egrep, which supports ?s...

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/5dd42d33cba8

I changed it to use what I think is the right syntax.