671465 - Misc build-system cleanups

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matheus Kerschbaum]

I keep hitting these when patching the build-system so I figured it was time to get rid of them!

Comment 1

[Matheus Kerschbaum]

Attachment: part 1: Remove whitespace from configure

Comment 2

[Matheus Kerschbaum]

Attachment: part 2: Remove tabs from configure

Comment 3

[Matheus Kerschbaum]

Attachment: part 3: Remove whitespace from autoconf

Comment 4

[Matheus Kerschbaum]

Attachment: part 4: Remove tabs from autoconf

Comment 5

[Matheus Kerschbaum]

Attachment: part 5: Remove whitespace from config.mk

Comment 6

[Matheus Kerschbaum]

Attachment: part 6: Remove tabs from config.mk

Comment 7

[Matheus Kerschbaum]

Attachment: part 7: Remove whitespace from rules.mk

Comment 8

[Matheus Kerschbaum]

Attachment: part 8: Remove tabs from rules.mk

Comment 9

[Matheus Kerschbaum]

Rubber-stamp please, no functionality changes in these patches.

Comment 10

[Matheus Kerschbaum]

And of course, none of this actually builds because configure hates me.

Comment 11

[Ed Morley [:emorley]]

I can't remember off-hand if check-sync-dirs.py considers whitespace in the file comparison - but (presuming it does) for builds to complete, the same changes will also need to be made to the js/src/config/ and js/src/build/ versions of files that don't appear in the exceptions list, if that helps at all?

http://mxr.mozilla.org/mozilla-central/source/js/src/Makefile.in#626
http://mxr.mozilla.org/mozilla-central/source/js/src/config/check-sync-dirs.py
http://mxr.mozilla.org/mozilla-central/source/js/src/config/check-sync-exceptions

Comment 12

[Matheus Kerschbaum]

check-sync-dirs.py doesn't prevent builds from compiling, it just turns the tree orange if you forget to change the js/src/ build system counterparts (like I did here).

The problem here is the second patch, which makes configures angry for some reason. All the other parts compile fine IIRC, but I don't know if this small cleanup is worth messing up hg log/blame.

Comment 13

[Matheus Kerschbaum]

Attachment: part 1: remove AC_SUBST(MINIMO) from configure

I decided to drop the mass tabs -> spaces change since it breaks configure and rules.mk and doing it manually would be painful. I also ended up removing some unrelated (to the whitespace cleanup) cruft in several places.

Comment 14

[Matheus Kerschbaum]

Attachment: part 2: Remove reference to dead MAKEFILES_sun_java variable in toolkit-makefiles.sh

Comment 15

[Matheus Kerschbaum]

Attachment: part 3: Remove some javaxpcom left-overs

Comment 16

[Matheus Kerschbaum]

Attachment: part 4: Remove some gtkmozembed left-overs

Comment 17

[Matheus Kerschbaum]

Attachment: part 5: remove whitespace from configure

Comment 18

[Matheus Kerschbaum]

Attachment: part 6: remove whitespace from autoconf

Comment 19

[Matheus Kerschbaum]

Attachment: part 7: remove whitespace from config.mk

Comment 20

[Matheus Kerschbaum]

Attachment: part 8: remove whitespace from rules.mk

Comment 21

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 555313 [details] [diff] [review]
part 5: remove whitespace from configure

Just skimmed this one, but it looks fine.

Comment 22

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 555314 [details] [diff] [review]
part 6: remove whitespace from autoconf

We can probably kill this NS_USE_NATIVE stuff ...

Comment 23

[Ed Morley [:emorley]]

http://hg.mozilla.org/projects/build-system/rev/03076dd9a84d
http://hg.mozilla.org/projects/build-system/rev/50492b07b13f
http://hg.mozilla.org/projects/build-system/rev/2932e726f86d
http://hg.mozilla.org/projects/build-system/rev/4cf43c7e1fae
http://hg.mozilla.org/projects/build-system/rev/5e9ae571d6b3
http://hg.mozilla.org/projects/build-system/rev/8f246ed75d3d
http://hg.mozilla.org/projects/build-system/rev/ca65995f24ec
http://hg.mozilla.org/projects/build-system/rev/f14ab53ee6d0

Comment 24

[Matheus Kerschbaum]

Attachment: bustage fix

Stupid me forgot to change the js/src bits again.

Comment 25

[Ed Morley [:emorley]]

Comment on attachment 555897 [details] [diff] [review]
bustage fix

http://hg.mozilla.org/projects/build-system/rev/718f1de3f105

Comment 26

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/03076dd9a84d
http://hg.mozilla.org/mozilla-central/rev/50492b07b13f
http://hg.mozilla.org/mozilla-central/rev/2932e726f86d
http://hg.mozilla.org/mozilla-central/rev/4cf43c7e1fae
http://hg.mozilla.org/mozilla-central/rev/5e9ae571d6b3
http://hg.mozilla.org/mozilla-central/rev/8f246ed75d3d
http://hg.mozilla.org/mozilla-central/rev/ca65995f24ec
http://hg.mozilla.org/mozilla-central/rev/f14ab53ee6d0
http://hg.mozilla.org/mozilla-central/rev/718f1de3f105