Closed
Bug 671475
Opened 13 years ago
Closed 13 years ago
IonMonkey does not build for arm
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mjrosenb, Assigned: mjrosenb)
Details
Attachments
(1 file)
2.99 KB,
patch
|
adrake
:
review+
|
Details | Diff | Splinter Review |
The new ion code expects arch specific code in js/src/ion/$ARCH, but so far that code has only been implemented for x86 and x64, leading to the ion branch not building on arm.
Attachment #545818 -
Flags: review?(adrake)
Comment 1•13 years ago
|
||
Comment on attachment 545818 [details] [diff] [review] turns off ion on arm, also creates a top level flag to turn off pic-typed-arrays Review of attachment 545818 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! ::: js/src/jsapi.cpp @@ +787,4 @@ > if (!mem) > return NULL; > > +#if defined(JS_METHODJIT) && defined(JS_ION) In jsinterp.cpp the guard is just "#ifdef JS_ION", so this probably should be the same. Checking METHODJIT too doesn't make too much sense to me: if Ion does end up depending on JM that should probably be handled somewhere more global (i.e. configure.in).
Attachment #545818 -
Flags: review?(adrake) → review+
Updated•13 years ago
|
Assignee: general → mrosenberg
Status: NEW → ASSIGNED
Put this patch in my queue since we're about to touch more engine stuff. It needs an AC_SUBST(ENABLE_ION) somewhere.
Argh, no, there's more... config/autoconf.mk needs: ENABLE_ION = @ENABLE_ION@ (I'm getting bad memories of dealing with this for ENABLE_METHODJIT)
http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/bb12acebda0f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•