671475 - IonMonkey does not build for arm

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Marty Rosenberg [:mjrosenb]]

Attachment: turns off ion on arm, also creates a top level flag to turn off pic-typed-arrays

The new ion code expects arch specific code in js/src/ion/$ARCH, but so far that code has only been implemented for x86 and x64, leading to the ion branch not building on arm.

Comment 1

[Andrew Drake [:adrake]]

Comment on attachment 545818 [details] [diff] [review]
turns off ion on arm, also creates a top level flag to turn off pic-typed-arrays

Review of attachment 545818 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: js/src/jsapi.cpp
@@ +787,4 @@
>      if (!mem)
>          return NULL;
>  
> +#if defined(JS_METHODJIT) && defined(JS_ION)

In jsinterp.cpp the guard is just "#ifdef JS_ION", so this probably should be the same. Checking METHODJIT too doesn't make too much sense to me: if Ion does end up depending on JM that should probably be handled somewhere more global (i.e. configure.in).

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Put this patch in my queue since we're about to touch more engine stuff. It needs an AC_SUBST(ENABLE_ION) somewhere.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Argh, no, there's more... config/autoconf.mk needs:
    ENABLE_ION = @ENABLE_ION@

(I'm getting bad memories of dealing with this for ENABLE_METHODJIT)

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/bb12acebda0f