671550 - provide correct parent HWND for content process window

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

JAWS doesn't work still, though it should, WM_GETOBJECT is handled, events are fired, get_accChild works.

How can I get a try build on electrolysis branch to share?

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Just push to try.

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> Just push to try.

Does it really build on electrolysis branch? I get build errors.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

All the relevant patches from electrolysis have been pushed to mozilla-central, you can just use m-c now.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 547082 [details] [diff] [review]
patch2

Review of attachment 547082 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. As far as I can tell we don't need to worry about config options here right?

::: accessible/src/msaa/nsDocAccessibleWrap.cpp
@@ +281,5 @@
>        nsRootAccessible* rootDocument = RootAccessible();
>  
> +      void* nativeData = nsnull;
> +      if (tabChild)
> +        tabChild->SendGetWidgetNativeData(&nativeData);

What about "SendGetWidgetHwnd"?

@@ +300,5 @@
>          docShell->GetIsActive(&isActive);
>        }
>  
> +      HWND parentWnd = static_cast<HWND>(nativeData);
> +      //HWND parentWnd = static_cast<HWND>(rootDocument->GetNativeWindow());

remove comment.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 547082 [details] [diff] [review]
patch2

Serializing voidPtr is overly general and misleading, so we've avoided it so far.  In bug 648484, we also need to serialize HWNDs and added a "WindowsHandle" helper thusly


diff --git a/ipc/glue/IPCMessageUtils.h b/ipc/glue/IPCMessageUtils.h
--- a/ipc/glue/IPCMessageUtils.h
+++ b/ipc/glue/IPCMessageUtils.h
@@ -68,16 +68,20 @@ namespace base { class FileDescriptor { 
 
 using mozilla::layers::LayerManager;
 
 namespace mozilla {
 
 typedef gfxPattern::GraphicsFilter GraphicsFilterType;
 typedef gfxASurface::gfxSurfaceType gfxSurfaceType;
 typedef LayerManager::LayersBackend LayersBackend;
+typedef gfxASurface::gfxImageFormat PixelFormat;
+// This is a cross-platform approximation to HANDLE, which we expect
+// to be typedef'd to void* or thereabouts.
+typedef uintptr_t WindowsHandle;


so that your protocol have have |using mozilla::WindowsHandle;|.  That bug has been backed out twice now :/, but I'd prefer you borrow that snipped instead of using voidPtr.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch3

Comment 8

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f1d496722775

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f1d496722775