Closed Bug 671632 Opened 11 years ago Closed 11 years ago
Nightly shark build broken
Looks like fallout from my landing of bug 588537, which included some bitrotted changes to starting/stopping profiling.
Whoops, Shark::Stop() doesn't return a bool. This compiled on my mac. (Sorry, Waldo, you made the mistake of having an empty review queue when I checked.)
Assignee: general → sphink
Status: NEW → ASSIGNED
Attachment #546024 - Flags: review?
Attachment #546024 - Flags: review? → review?(jwalden+bmo)
Comment on attachment 546024 [details] [diff] [review] Fix the Shark build Cancelling review request because I'm seeing a failure linking a test.
Attachment #545977 - Attachment is obsolete: true
Comment on attachment 546024 [details] [diff] [review] Fix the Shark build Oh. The failure was a pre-existing problem with Shark and --enable-shared-js. That should be fixed separately. I'm leaving in half a fix simply because it's what I pushed to Try successfully; I can push another without it if you'd like.
Attachment #546024 - Flags: review?(jwalden+bmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.