671632 - Nightly shark build broken

Status: RESOLVED FIXED

Description

[Steve Fink [:sfink] [:s:]]

Created attachment 545977 [details] [diff] [review]
Fix the Shark build

Looks like fallout from my landing of bug 588537, which included some bitrotted changes to starting/stopping profiling.

Comment 1

[Steve Fink [:sfink] [:s:]]

Created attachment 546024 [details] [diff] [review]
Fix the Shark build

Whoops, Shark::Stop() doesn't return a bool.

This compiled on my mac.

(Sorry, Waldo, you made the mistake of having an empty review queue when I checked.)

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build

Cancelling review request because I'm seeing a failure linking a test.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build

Oh. The failure was a pre-existing problem with Shark and --enable-shared-js. That should be fixed separately. I'm leaving in half a fix simply because it's what I pushed to Try successfully; I can push another without it if you'd like.

Comment 4

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/bf955b263587

Comment 5

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/bf955b263587