Closed Bug 671632 Opened 9 years ago Closed 9 years ago

Nightly shark build broken

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file, 1 obsolete file)

Fix the Shark build
1.33 KB, patch
Waldo
: review+
Details | Diff | Splinter Review
Attached patch Fix the Shark build (obsolete) — — Splinter Review 
Looks like fallout from my landing of bug 588537, which included some bitrotted changes to starting/stopping profiling.
Whoops, Shark::Stop() doesn't return a bool.

This compiled on my mac.

(Sorry, Waldo, you made the mistake of having an empty review queue when I checked.)
Assignee: general → sphink
Status: NEW → ASSIGNED
Attachment #546024 - Flags: review?
OS: Linux → Mac OS X
Attachment #546024 - Flags: review? → review?(jwalden+bmo)
Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build

Cancelling review request because I'm seeing a failure linking a test.
Attachment #546024 - Flags: review?(jwalden+bmo)
Attachment #545977 - Attachment is obsolete: true
Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build

Oh. The failure was a pre-existing problem with Shark and --enable-shared-js. That should be fixed separately. I'm leaving in half a fix simply because it's what I pushed to Try successfully; I can push another without it if you'd like.
Attachment #546024 - Flags: review?(jwalden+bmo)
Attachment #546024 - Flags: review?(jwalden+bmo) → review+
http://hg.mozilla.org/mozilla-central/rev/bf955b263587
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.