Closed
Bug 671632
Opened 14 years ago
Closed 14 years ago
Nightly shark build broken
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file, 1 obsolete file)
|
1.33 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Looks like fallout from my landing of bug 588537, which included some bitrotted changes to starting/stopping profiling.
|
Assignee | |
Comment 1•14 years ago
|
||
Whoops, Shark::Stop() doesn't return a bool.
This compiled on my mac.
(Sorry, Waldo, you made the mistake of having an empty review queue when I checked.)
|
||
Updated•14 years ago
|
OS: Linux → Mac OS X
|
|
Assignee | |
Updated•14 years ago
|
Attachment #546024 -
Flags: review? → review?(jwalden+bmo)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build
Cancelling review request because I'm seeing a failure linking a test.
Attachment #546024 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #545977 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build
Oh. The failure was a pre-existing problem with Shark and --enable-shared-js. That should be fixed separately. I'm leaving in half a fix simply because it's what I pushed to Try successfully; I can push another without it if you'd like.
Attachment #546024 -
Flags: review?(jwalden+bmo)
|
||
Updated•14 years ago
|
Attachment #546024 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•