The default bug view has changed. See this FAQ.

Nightly shark build broken

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 545977 [details] [diff] [review]
Fix the Shark build

Looks like fallout from my landing of bug 588537, which included some bitrotted changes to starting/stopping profiling.
(Assignee)

Comment 1

6 years ago
Created attachment 546024 [details] [diff] [review]
Fix the Shark build

Whoops, Shark::Stop() doesn't return a bool.

This compiled on my mac.

(Sorry, Waldo, you made the mistake of having an empty review queue when I checked.)
Assignee: general → sphink
Status: NEW → ASSIGNED
Attachment #546024 - Flags: review?
OS: Linux → Mac OS X
(Assignee)

Updated

6 years ago
Attachment #546024 - Flags: review? → review?(jwalden+bmo)
(Assignee)

Comment 2

6 years ago
Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build

Cancelling review request because I'm seeing a failure linking a test.
Attachment #546024 - Flags: review?(jwalden+bmo)
(Assignee)

Updated

6 years ago
Attachment #545977 - Attachment is obsolete: true
(Assignee)

Comment 3

6 years ago
Comment on attachment 546024 [details] [diff] [review]
Fix the Shark build

Oh. The failure was a pre-existing problem with Shark and --enable-shared-js. That should be fixed separately. I'm leaving in half a fix simply because it's what I pushed to Try successfully; I can push another without it if you'd like.
Attachment #546024 - Flags: review?(jwalden+bmo)
Attachment #546024 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/bf955b263587
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/bf955b263587
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.