671798 - Prefs from $gre/defaults/pref are not used in some cases

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Mike Hommey [:glandium]]

After bug 620931, $gre/defaults/pref/*.js files are supposed to only be loaded when the application directory and the GRE directory are the same. That was the intent, but the code actually doesn't do that because of the semantics change that happened late in bug 620931. What the code currently does is that it will load $gre/defaults/pref/*.js unless there's an the application directory and the GRE directory are different and the application uses an omni.jar.

This means it works in all cases for plain Firefox but doesn't with xulrunner when the app is omnijar'ed. But xulrunner has its own prefs in $gre/defaults/pref/*.js, most notably when xulrunner itself is not omnijar'ed (like, when running it from the dist/bin directory).

This means we actually have a need to unconditionally load these prefs instead of skipping in some cases.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Always load $gre/defaults/pref prefs

Comment 2

[Mike Hommey [:glandium]]

Attachment: Same patch, as diff -w

Comment 3

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/366a1e04921c

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/366a1e04921c