The default bug view has changed. See this FAQ.

Prefs from $gre/defaults/pref are not used in some cases

RESOLVED FIXED in mozilla8

Status

()

Core
Preferences: Backend
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
After bug 620931, $gre/defaults/pref/*.js files are supposed to only be loaded when the application directory and the GRE directory are the same. That was the intent, but the code actually doesn't do that because of the semantics change that happened late in bug 620931. What the code currently does is that it will load $gre/defaults/pref/*.js unless there's an the application directory and the GRE directory are different and the application uses an omni.jar.

This means it works in all cases for plain Firefox but doesn't with xulrunner when the app is omnijar'ed. But xulrunner has its own prefs in $gre/defaults/pref/*.js, most notably when xulrunner itself is not omnijar'ed (like, when running it from the dist/bin directory).

This means we actually have a need to unconditionally load these prefs instead of skipping in some cases.
(Assignee)

Updated

6 years ago
Blocks: 671804
(Assignee)

Comment 1

6 years ago
Created attachment 547346 [details] [diff] [review]
Always load $gre/defaults/pref prefs
Attachment #547346 - Flags: review?(benjamin)
(Assignee)

Comment 2

6 years ago
Created attachment 547347 [details] [diff] [review]
Same patch, as diff -w
Assignee: nobody → mh+mozilla
(Assignee)

Updated

6 years ago
No longer blocks: 671804
Attachment #547346 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/366a1e04921c
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/366a1e04921c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.