Closed Bug 671798 Opened 9 years ago Closed 9 years ago

Prefs from $gre/defaults/pref are not used in some cases

Categories

(Core :: Preferences: Backend, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

After bug 620931, $gre/defaults/pref/*.js files are supposed to only be loaded when the application directory and the GRE directory are the same. That was the intent, but the code actually doesn't do that because of the semantics change that happened late in bug 620931. What the code currently does is that it will load $gre/defaults/pref/*.js unless there's an the application directory and the GRE directory are different and the application uses an omni.jar.

This means it works in all cases for plain Firefox but doesn't with xulrunner when the app is omnijar'ed. But xulrunner has its own prefs in $gre/defaults/pref/*.js, most notably when xulrunner itself is not omnijar'ed (like, when running it from the dist/bin directory).

This means we actually have a need to unconditionally load these prefs instead of skipping in some cases.
Blocks: 671804
Attachment #547346 - Flags: review?(benjamin)
Assignee: nobody → mh+mozilla
No longer blocks: 671804
Attachment #547346 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/366a1e04921c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.