671859 - Use GetExplicit and GetResident methods in NSIMemoryReporterManager for endurance tests metrics

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Now that bug 660731 has landed, we should use the explicit and resident properties of the memory reporter manager.

Comment 1

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15824655

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Use getExplicit and getResident methods in NSIMemoryReporterManager. v1.0

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 546167 [details] [diff] [review]
Use getExplicit and getResident methods in NSIMemoryReporterManager. v1.0

Review of attachment 546167 [details] [diff] [review]:
-----------------------------------------------------------------

That looks a lot simpler :)

One thing -- memMgr.explicit and memMgr.resident can be -1 if something went wrong.  Is this handled?

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This will be handled by bug 661245. Thanks for the reminder.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 546167 [details] [diff] [review]
Use getExplicit and getResident methods in NSIMemoryReporterManager. v1.0

Looks fantastic. I kinda like this drop of extra code.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/d7c5d9242799 (default)