Last Comment Bug 672040 - Hunspell test suite is still generated when using --disable-tests
: Hunspell test suite is still generated when using --disable-tests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Spelling checker (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: 629734
  Show dependency treegraph
 
Reported: 2011-07-16 06:57 PDT by Ed Morley [:emorley]
Modified: 2011-07-17 17:34 PDT (History)
2 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (980 bytes, patch)
2011-07-16 07:04 PDT, Ed Morley [:emorley]
khuey: review+
Details | Diff | Review
Patch v1 (982 bytes, patch)
2011-07-16 15:41 PDT, Ed Morley [:emorley]
emorley: review+
Details | Diff | Review

Description Ed Morley [:emorley] 2011-07-16 06:57:20 PDT
Bug 629734 added the Hunspell test suite into the tree, but the build system changes (http://hg.mozilla.org/mozilla-central/rev/f99b6caaaff9) do not |ifdef ENABLE_TESTS|, so the test suite is still generated even when using --disable-tests.
Comment 1 Ed Morley [:emorley] 2011-07-16 07:04:26 PDT
Created attachment 546322 [details] [diff] [review]
Patch v1

Two line change, adding |ifdef ENABLE_TESTS| to the test-specific lines in the Hunspell makefile.
Comment 2 Ed Morley [:emorley] 2011-07-16 09:57:31 PDT
http://dev.philringnalda.com/tbpl/?tree=Try&rev=145f59772117
Comment 3 Ed Morley [:emorley] 2011-07-16 15:35:11 PDT
The previous try pass was broken by one of the other changesets in the push. Submitted again without that and passed:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=556cec8038c2
Comment 4 Ed Morley [:emorley] 2011-07-16 15:41:13 PDT
Created attachment 546358 [details] [diff] [review]
Patch v1

No changes other than updated commit message for r=khuey; carrying forwards r+.

Has passed try (comment 3).
Comment 6 Joe Drew (not getting mail) 2011-07-17 17:34:01 PDT
http://hg.mozilla.org/mozilla-central/rev/8e5f130a6640

Note You need to log in before you can comment on or make changes to this bug.