The default bug view has changed. See this FAQ.

Hunspell test suite is still generated when using --disable-tests

RESOLVED FIXED in mozilla8

Status

()

Core
Spelling checker
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 629734 added the Hunspell test suite into the tree, but the build system changes (http://hg.mozilla.org/mozilla-central/rev/f99b6caaaff9) do not |ifdef ENABLE_TESTS|, so the test suite is still generated even when using --disable-tests.
Created attachment 546322 [details] [diff] [review]
Patch v1

Two line change, adding |ifdef ENABLE_TESTS| to the test-specific lines in the Hunspell makefile.
Attachment #546322 - Flags: review?(ted.mielczarek)
Attachment #546322 - Flags: review?(ted.mielczarek) → review+
http://dev.philringnalda.com/tbpl/?tree=Try&rev=145f59772117
The previous try pass was broken by one of the other changesets in the push. Submitted again without that and passed:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=556cec8038c2
Created attachment 546358 [details] [diff] [review]
Patch v1

No changes other than updated commit message for r=khuey; carrying forwards r+.

Has passed try (comment 3).
Attachment #546322 - Attachment is obsolete: true
Attachment #546358 - Flags: review+
Keywords: checkin-needed
Flags: in-testsuite-
http://hg.mozilla.org/integration/mozilla-inbound/rev/8e5f130a6640
Keywords: checkin-needed
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/8e5f130a6640
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.