Closed
Bug 672040
Opened 14 years ago
Closed 14 years ago
Hunspell test suite is still generated when using --disable-tests
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
|
982 bytes,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
Bug 629734 added the Hunspell test suite into the tree, but the build system changes (http://hg.mozilla.org/mozilla-central/rev/f99b6caaaff9) do not |ifdef ENABLE_TESTS|, so the test suite is still generated even when using --disable-tests.
|
Assignee | |
Comment 1•14 years ago
|
||
Two line change, adding |ifdef ENABLE_TESTS| to the test-specific lines in the Hunspell makefile.
Attachment #546322 -
Flags: review?(ted.mielczarek)
Attachment #546322 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Comment 3•14 years ago
|
||
The previous try pass was broken by one of the other changesets in the push. Submitted again without that and passed:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=556cec8038c2
|
|
Assignee | |
Comment 4•14 years ago
|
||
No changes other than updated commit message for r=khuey; carrying forwards r+.
Has passed try (comment 3).
Attachment #546322 -
Attachment is obsolete: true
Attachment #546358 -
Flags: review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Flags: in-testsuite-
|
||
Comment 5•14 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla8
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•