672079 - bad handling of single quotes inside HTTP Link header fields

Status: RESOLVED FIXED

Description

[Julian Reschke]

The parser for Link header fields treats single quotes just like double quotes.

In some cases, this is just an annoyance because it accepts values other UAs may not accept:

  http://greenbytes.de/tech/tc/httplink/#simplecsssq

What's worse is that it misinterprets valid parameters that use the token format, where the single quote is a "normal" character without special treatment:

  http://greenbytes.de/tech/tc/httplink/#simplecsstitle5987r

I recommend simply removing the special casing for single quotes. This fixes the second test case, and established parity with Opera in the first one.

Comment 1

[Julian Reschke]

Created attachment 548306 [details] [diff] [review]
remove special treatment of single quotes

This fixes two more cases on http://greenbytes.de/tech/tc/httplink/

Comment 2

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Comment on attachment 548306 [details] [diff] [review]
remove special treatment of single quotes

OK, let's give this a shot....

Comment 3

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/37dcfd002ab0

Comment 4

[Marco Bonardo [::mak]]

http://hg.mozilla.org/mozilla-central/rev/37dcfd002ab0