Closed
Bug 672079
Opened 14 years ago
Closed 14 years ago
bad handling of single quotes inside HTTP Link header fields
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: julian.reschke, Assigned: julian.reschke)
References
()
Details
Attachments
(1 file)
|
1003 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The parser for Link header fields treats single quotes just like double quotes.
In some cases, this is just an annoyance because it accepts values other UAs may not accept:
http://greenbytes.de/tech/tc/httplink/#simplecsssq
What's worse is that it misinterprets valid parameters that use the token format, where the single quote is a "normal" character without special treatment:
http://greenbytes.de/tech/tc/httplink/#simplecsstitle5987r
I recommend simply removing the special casing for single quotes. This fixes the second test case, and established parity with Opera in the first one.
|
Assignee | |
Comment 1•14 years ago
|
||
This fixes two more cases on http://greenbytes.de/tech/tc/httplink/
Attachment #548306 -
Flags: review?(bzbarsky)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 548306 [details] [diff] [review]
remove special treatment of single quotes
OK, let's give this a shot....
Attachment #548306 -
Flags: review?(bzbarsky) → review+
|
|
||
Updated•14 years ago
|
Assignee: nobody → julian.reschke
Keywords: checkin-needed
|
|
||
Comment 3•14 years ago
|
||
Flags: in-testsuite?
Keywords: checkin-needed
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•