The default bug view has changed. See this FAQ.

bad handling of single quotes inside HTTP Link header fields

RESOLVED FIXED in mozilla8

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Julian Reschke, Assigned: Julian Reschke)

Tracking

unspecified
mozilla8
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The parser for Link header fields treats single quotes just like double quotes.

In some cases, this is just an annoyance because it accepts values other UAs may not accept:

  http://greenbytes.de/tech/tc/httplink/#simplecsssq

What's worse is that it misinterprets valid parameters that use the token format, where the single quote is a "normal" character without special treatment:

  http://greenbytes.de/tech/tc/httplink/#simplecsstitle5987r

I recommend simply removing the special casing for single quotes. This fixes the second test case, and established parity with Opera in the first one.
(Assignee)

Comment 1

6 years ago
Created attachment 548306 [details] [diff] [review]
remove special treatment of single quotes

This fixes two more cases on http://greenbytes.de/tech/tc/httplink/
Attachment #548306 - Flags: review?(bzbarsky)
Comment on attachment 548306 [details] [diff] [review]
remove special treatment of single quotes

OK, let's give this a shot....
Attachment #548306 - Flags: review?(bzbarsky) → review+
Assignee: nobody → julian.reschke
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/37dcfd002ab0
Flags: in-testsuite?
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/37dcfd002ab0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.