Closed Bug 672079 Opened 8 years ago Closed 8 years ago

bad handling of single quotes inside HTTP Link header fields

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: julian.reschke, Assigned: julian.reschke)

References

(
URL
)

Details

Attachments

(1 file)

remove special treatment of single quotes
1003 bytes, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
The parser for Link header fields treats single quotes just like double quotes.

In some cases, this is just an annoyance because it accepts values other UAs may not accept:

  http://greenbytes.de/tech/tc/httplink/#simplecsssq

What's worse is that it misinterprets valid parameters that use the token format, where the single quote is a "normal" character without special treatment:

  http://greenbytes.de/tech/tc/httplink/#simplecsstitle5987r

I recommend simply removing the special casing for single quotes. This fixes the second test case, and established parity with Opera in the first one.
This fixes two more cases on http://greenbytes.de/tech/tc/httplink/
Attachment #548306 - Flags: review?(bzbarsky)
Comment on attachment 548306 [details] [diff] [review]
remove special treatment of single quotes

OK, let's give this a shot....
Attachment #548306 - Flags: review?(bzbarsky) → review+
Assignee: nobody → julian.reschke
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/37dcfd002ab0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.