Closed Bug 672087 Opened 13 years ago Closed 13 years ago

Use explicit require statements in SDK modules.

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: irakli, Assigned: irakli)

Details

Attachments

(1 file, 1 obsolete file)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/213
355 bytes, text/html
warner
: review+
Details 
Since module search depends on dependencies SDK packages have to use explicit require to avoid errors caused by search.
Attachment #546363 - Flags: review?(warner-bugzilla)
Assignee: nobody → rFobic
Status: NEW → ASSIGNED
Comment on attachment 546363 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/213

looks good to me, although apparently it needs some merge work to apply cleanly to current trunk. Assuming that work doesn't break anything, I'm r+.
Attachment #546363 - Flags: review?(warner-bugzilla) → review+
Landed:

https://github.com/mozilla/addon-sdk/commit/94fa2de42c57a42f7272c2e1ae26e81a210e2419
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
This landing broke tests on debug builds with exceptions like:

ReferenceError: assignment to undeclared variable name (resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/components/harness.js:170)
stack:
buildLoader()@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/components/harness.js:170
()@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/components/harness.js:281
Harness_load("startup")@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/components/harness.js:309
Harness_observe(null,"sessionstore-windows-restored","")@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/xulapp@toolness.com/components/harness.js:374
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Here's a fix for at least some of the exceptions, although it might not be complete.
Attachment #547538 - Flags: review?(rFobic)
Comment on attachment 547538 [details] [diff] [review]
fix for some or all of the exceptions

Erm, wrong bug; never mind.
Attachment #547538 - Attachment is obsolete: true
Attachment #547538 - Flags: review?(rFobic)
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: