672087 - Use explicit require statements in SDK modules.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Since module search depends on dependencies SDK packages have to use explicit require to avoid errors caused by search.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/213

Pointer to Github pull-request

Comment 2

[Brian Warner [:warner :bwarner]]

Comment on attachment 546363 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/213

looks good to me, although apparently it needs some merge work to apply cleanly to current trunk. Assuming that work doesn't break anything, I'm r+.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Landed:

https://github.com/mozilla/addon-sdk/commit/94fa2de42c57a42f7272c2e1ae26e81a210e2419

Comment 4

[Myk Melez [:myk] [@mykmelez]]

This landing broke tests on debug builds with exceptions like:

ReferenceError: assignment to undeclared variable name (resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/components/harness.js:170)
stack:
buildLoader()@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/components/harness.js:170
()@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/components/harness.js:281
Harness_load("startup")@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/components/harness.js:309
Harness_observe(null,"sessionstore-windows-restored","")@resource://gre/modules/XPIProvider.jsm -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/bootstrap.js -> file:///tmp/tmpt1_V80.mozrunner/extensions/[e-mail]/components/harness.js:374

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Attachment: fix for some or all of the exceptions

Here's a fix for at least some of the exceptions, although it might not be complete.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 547538 [details] [diff] [review]
fix for some or all of the exceptions

Erm, wrong bug; never mind.