672127 - Cached OCSP response should not be deleted unless/until replacement is fully constructed

Status: NEW

(NSS :: Libraries, defect, P5)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #663733 +++

In ocsp_CreateOrUpdateCacheEntry, there is this code:

        rv = ocsp_SetCacheItemResponse(cacheItem, single);
        if (rv != SECSuccess) {
            ocsp_RemoveCacheItem(cache, cacheItem);
            PR_ExitMonitor(OCSP_Global.monitor);
            return rv;
        }

ocsp_SetCacheItemResponse should be atomic, so that if there is any failure, cacheItem is unchanged. Then, the call to ocsp_RemoveCacheItem must be removed. This way, a bad single response or a failure copying it will not destroy information in the cache.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

There might be another problem, where the cache entry's arena will grow each time the status is replaced, because the same arena is used for each version.