672139 - Graph server shouldn't use URIs containing square brackets

Status: RESOLVED DUPLICATE of bug 489740

(Webtools Graveyard :: Graph Server, defect)

Description

[Justin Lebar (not reading bugmail)]

According to RFC 3986, URIs must not contain [ and ] outside the host section:

   A host identified by an Internet Protocol literal address, version 6
   [RFC3513] or later, is distinguished by enclosing the IP literal
   within square brackets ("[" and "]").  This is the only place where
   square bracket characters are allowed in the URI syntax.

But Graphserver creates such URIs.  In addition to violating the spec, such URIs confuse bugzilla's URI highlighting (see bug 670998).

Comment 1

[Robert Helmer [:rhelmer]]

The current format of graphserver URLs has been bugging me for a while (and is a common source of complaints). I'd really like to change this.

Since we're not 100% backwards compatible with old graphserver links anyway, I'd like to do this before taking over the graphs.m.o URL (perhaps with a way to detect and convert old-style URLs, or at the very least display a message that it's not supported).

There are a few other bugs on this subject:
bug 487116
bug 489740

Not sure if either of these are a direct DUP, probably bug 489740.

Comment 2

[Justin Lebar (not reading bugmail)]

If backwards-compatibility is important, you could still accept the old-style URLs, but provide better URLs.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to comment #2)
> If backwards-compatibility is important, you could still accept the
> old-style URLs, but provide better URLs.

The primary problem with backwards compatibility is that the old URLs mean:
[test,branch,machine]

While the new URLs mean:
[test,branch,platform]

With platform containing all machines (showing average by default). They originally were 100% backwards compatible, keeping the old-style URLs while changing the meaning of one of the positional elements was definitely a mistake.

The best way forward is probably to:

1) introduce a new URL format, breaking links to the current 2.0 servers
2) treat [,,n] as machineID, and lookup the platform it's in