672158 - Custom repeated task - cannot click on OK button

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[hnsz2002]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 2011061500

Steps to reproduce:

I want to create a custom repeated task until a date. New task, Repeat: Custom, and if select Repeat until radiobutton, if i click on OK, it has no effect, and cannot save the settings.
(This bug is also available in earlier beta versions...)


Actual results:

The dialog window not closed, and the settings are't saved.


Expected results:

Close the window, and create repeated task until the selected date.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Do you have any error console messages afterwards?

Comment 2

[hnsz2002]

(In reply to comment #1)
> Do you have any error console messages afterwards?

Yeah, http://wstaw.org/m/2011/07/19/lightning.png

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Are you using a localized build, or is this en-US?

Comment 4

[Decathlon]

The following locales have errors that cause a such message error.

Serbian:
http://mxr.mozilla.org/l10n-mozilla-beta/source/sr/calendar/chrome/calendar/calendar-event-dialog.properties#353
http://mxr.mozilla.org/l10n-mozilla-beta/source/sr/calendar/chrome/calendar/calendar-event-dialog.properties#359

Norwegian:
http://mxr.mozilla.org/l10n-mozilla-beta/source/nn-NO/calendar/chrome/calendar/calendar-event-dialog.properties#359

Hebrew:
http://mxr.mozilla.org/l10n-mozilla-beta/source/he/calendar/chrome/calendar/calendar-event-dialog.properties#153
http://mxr.mozilla.org/l10n-mozilla-beta/source/he/calendar/chrome/calendar/calendar-event-dialog.properties#160
http://mxr.mozilla.org/l10n-mozilla-beta/source/he/calendar/chrome/calendar/calendar-event-dialog.properties#167

Hungarian:
http://mxr.mozilla.org/l10n-mozilla-beta/source/hu/calendar/chrome/calendar/calendar-event-dialog.properties#359

Romanian:
http://mxr.mozilla.org/l10n-mozilla-beta/source/ro/calendar/chrome/calendar/calendar-event-dialog.properties#257

Comment 5

[hnsz2002]

(In reply to comment #3)
> Are you using a localized build, or is this en-US?

Its a localized version, hu-HU

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Ok, so we need to either guard better or fix the locales, as fast as possible. I am in the process of spinning 1.0b5rc1, but I think its reasonable to push in a fix for this bug too.

Decathlon, could you spin up a patch to guard better on the calendar side?

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This should take care of the calendar side and at least allow usage of the dialog again. I'll contact localizers to see that they fix the errors.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 547389 [details] [diff] [review]
Fix - v1

I'm going to check this in for the sake of a quicker release.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3654eb8aa8e9>
-> FIXED

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/d5153e2e084a>

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/3b341ab1e13f>

Comment 12

[Decathlon]

Comment on attachment 547389 [details] [diff] [review]
Fix - v1

># HG changeset patch
># Parent 2978cc4dce9e7a1b35e72c737bd8a5e173d07a66
>Fix bug 672158 - Custom repeated task - cannot click on OK button. r=decathlon
>
>diff -r 2978cc4dce9e calendar/base/content/dialogs/calendar-event-dialog-recurrence.js
>--- a/calendar/base/content/dialogs/calendar-event-dialog-recurrence.js	Thu Jul 21 12:31:27 2011 +0200
>+++ b/calendar/base/content/dialogs/calendar-event-dialog-recurrence.js	Thu Jul 21 15:46:23 2011 +0200
>@@ -762,8 +762,11 @@
>     // Add elements in the right order, removing them from their old parent
>     for (var i = 0; i < aPropParams.length; i++) {
>         var newEl = document.getElementById(localeOrder[i]);
>-        parents[i].appendChild(newEl.parentNode.removeChild(newEl));
>-
>+        if (newEl) {
>+            parents[i].appendChild(newEl.parentNode.removeChild(newEl));
>+        } else {
>+            cal.ERROR("Localization error, could not find node '" + localeOrder[i] + "'. Please have your localizer check the string '" + aPropKey + "'");
>+        }
>     }
> }
> 
>diff -r 2978cc4dce9e calendar/locales/en-US/chrome/calendar/calendar-event-dialog.properties
>--- a/calendar/locales/en-US/chrome/calendar/calendar-event-dialog.properties	Thu Jul 21 12:31:27 2011 +0200
>+++ b/calendar/locales/en-US/chrome/calendar/calendar-event-dialog.properties	Thu Jul 21 15:46:23 2011 +0200
>@@ -130,6 +130,7 @@
> # %1$S - ordinal with article
> # %2$S - weekday noun
> # e.g. "'the first' 'Monday'"
>+# DONT_TRANSLATE: Make sure there are no extra words in this property, just variables.
> ordinalWeekdayOrder=%1$S %2$S
> 
> # LOCALIZATION NOTE (monthlyEveryOfEveryNounclass...):
>@@ -350,18 +351,21 @@
> # Edit recurrence window -> Recurrence pattern -> Repeat monthly
> # %1$S - ordinal with article, %2$S - weekday
> # e.g. "the First Saturday"
>+# DONT_TRANSLATE: Make sure there are no extra words in this property, just variables.
> monthlyOrder=%1$S %2$S
> 
> # Edit recurrence window -> Recurrence pattern -> Repeat yearly
> # %1$S - day of month, %2$S - of, %3$S - month
> # e.g. "6 [of] September"
> # If you don't need %2$S in your locale - please put this on the third place.
>+# DONT_TRANSLATE: Make sure there are no extra words in this property, just variables.
> yearlyOrder=%1$S %3$S %2$S
> 
> # Edit recurrence window -> Recurrence pattern -> Repeat yearly
> # %1$S - ordinal with article, %2$S - weekday, %3$S  - of, %4$S - month
> # e.g. "the First Saturday of September"
> # If you don't need %3$S in your locale - please put this on the third place.
>+# DONT_TRANSLATE: Make sure there are no extra words in this property, just variables.
> yearlyOrder2=%1$S %2$S %3$S %4$S
> 
> # LOCALIZATION NOTE (pluralForWeekdays):

Comment 13

[Decathlon]

Opps, sorry for the mess in the previous comment. I had not seen you already checked-in the patch.

There are other localization error related to this issue
http://mxr.mozilla.org/l10n-mozilla-aurora/source/eu/calendar/chrome/calendar/calendar-event-dialog.dtd#293

and maybe:
http://mxr.mozilla.org/l10n-mozilla-aurora/source/da/calendar/chrome/calendar/calendar-event-dialog.dtd#307

I'm going to send an email to the localizers.

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Thanks! I already have reply from two localizers from the first batch.