672267 - [accounts] Reduce flicker of login/user name in the upper-right hand corner

Status: RESOLVED WORKSFORME

(Webtools Graveyard :: Elmo, defect, P3)

Description

[Peter Bengtsson [:peterbe]]

There's a slight flicker because it waits for DOM to load, jquery to load and the `document.ready` event to trigger. It would be nice if we could optimize this so there's less flicker. 

Ideas...
* don't wait for the DOM to load fully, fire as soon as jquery is downloaded
* consider a tiny AJAX lib code (independent of jQuery) that loads the AJAX as soon as the DOM node is loaded
* write a javascript cookie on successful AJAX loads that can be used as a temporary display till AJAX is fired and callback'ed. 
* ...other ideas?

Comment 1

[Axel Hecht [:Pike]]

It's not so bad if the log-in shows with a delay, what I'm more concerned with is the flicker between "Log in" and "Hi Axel". That's switching between "an open action item" to "you're good to work here", which is rather confusing.

Going from nothing to "Hi Axel" would be much better already.

Thus, a least cost alternative would be to just kick off the ajax load without a $(), and to hide the "Log in" link by default. Which makes me think, Peter, why do we have that link? I wonder if we'd actually trigger the ready() handler if someone clicks on that #login link?

Comment 2

[Peter Bengtsson [:peterbe]]

Attachment: Extra client side cookie solution to reduce flicker to nil

This is a solution to "the second problem". Ie. once logged in, whilst waiting for the page plus first AJAX to complete it replaces "Log in" with your username. 

The "first problem" was that it used to start with a load indicator, the fire the AJAX and upon result of that callback replace the load indicator with either "Log in" or your user name.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 549087 [details] [diff] [review]
Extra client side cookie solution to reduce flicker to nil

I'm finally doing an r- on this one.

I bet the patch doesn't apply cleanly no more at this point anyway, and having the code (eval of compressed js? yuck) in there doesn't balance the downsides of the current behaviour.

Also just going to resolve this bug WORKSFORME, we've got bigger fish to fry. We can reopen if we get complaints from the community.