Last Comment Bug 672283 - eval cache should hit if both 'principals' and 'script->principals' are null
: eval cache should hit if both 'principals' and 'script->principals' are null
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla8
Assigned To: Luke Wagner [:luke]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-18 11:02 PDT by Luke Wagner [:luke]
Modified: 2011-07-19 08:15 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
make shell go fast again (1.86 KB, patch)
2011-07-18 14:42 PDT, Luke Wagner [:luke]
mrbkap: review+
Details | Diff | Splinter Review

Description Luke Wagner [:luke] 2011-07-18 11:02:53 PDT
bug 657418 comment 12 points out that the (#4 top-crash fixing) patch in bug 657418 effectively disables the eval cache for the shell (where most principals are NULL).  This can be fixed by a simple tweak to EvalCacheLookup logic so that you still get a hit (just without crashing).
Comment 1 Luke Wagner [:luke] 2011-07-18 14:42:42 PDT
Created attachment 546640 [details] [diff] [review]
make shell go fast again

Confirmed 20ms speedup (over de-optimized trunk) in shell.
Comment 2 Marco Bonardo [::mak] 2011-07-19 08:15:58 PDT
http://hg.mozilla.org/mozilla-central/rev/9d59a278cece

Note You need to log in before you can comment on or make changes to this bug.