eval cache should hit if both 'principals' and 'script->principals' are null

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
bug 657418 comment 12 points out that the (#4 top-crash fixing) patch in bug 657418 effectively disables the eval cache for the shell (where most principals are NULL).  This can be fixed by a simple tweak to EvalCacheLookup logic so that you still get a hit (just without crashing).
(Assignee)

Comment 1

6 years ago
Created attachment 546640 [details] [diff] [review]
make shell go fast again

Confirmed 20ms speedup (over de-optimized trunk) in shell.
Attachment #546640 - Flags: review?(mrbkap)

Updated

6 years ago
Attachment #546640 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/mozilla-central/rev/9d59a278cece
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.