Closed Bug 672283 Opened 10 years ago Closed 10 years ago

eval cache should hit if both 'principals' and 'script->principals' are null

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

bug 657418 comment 12 points out that the (#4 top-crash fixing) patch in bug 657418 effectively disables the eval cache for the shell (where most principals are NULL).  This can be fixed by a simple tweak to EvalCacheLookup logic so that you still get a hit (just without crashing).
Confirmed 20ms speedup (over de-optimized trunk) in shell.
Attachment #546640 - Flags: review?(mrbkap)
Attachment #546640 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/mozilla-central/rev/9d59a278cece
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.