The default bug view has changed. See this FAQ.

warning: unused variable 'oldValue' in nsMathMLmpaddedFrame::UpdateValue

RESOLVED FIXED in mozilla8

Status

()

Core
MathML
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: fredw, Assigned: nigelb)

Tracking

(Blocks: 1 bug, {helpwanted})

Trunk
mozilla8
helpwanted
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
In nsMathMLmpaddedFrame::UpdateValue, the variable oldValue became unused after

http://hg.mozilla.org/mozilla-central/rev/b28932f43641

and should be removed.
(Assignee)

Updated

6 years ago
Assignee: nobody → nigelbabu
Status: NEW → ASSIGNED

Updated

6 years ago
Blocks: 187528
(Assignee)

Comment 1

6 years ago
Created attachment 548021 [details] [diff] [review]
remove oldvalue

Attached patch removes the line
Attachment #548021 - Flags: review?(roc)
Attachment #548021 - Flags: review?(karlt)
Blocks: 557474
Attachment #548021 - Flags: review?(roc)
Attachment #548021 - Flags: review?(karlt)
Attachment #548021 - Flags: review+
Nigel, if you can attach a patch generated as explained on <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>, we can get it checked in for you.
(Assignee)

Comment 3

6 years ago
Created attachment 549344 [details] [diff] [review]
remove-oldvalue

Patch in the right format for check-in
Attachment #548021 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
Created attachment 549345 [details] [diff] [review]
rename-oldvalue v3

v3 of the patch with reviewer's name in the commit
Attachment #549344 - Attachment is obsolete: true
Thanks! Landed on inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/691c76a1a455

Someone will probably merge it over to mozilla-central later today (for some value of "today").
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/691c76a1a455
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Thanks Nigel, one step closer for bug 187528 :-)
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.