672444 - warning: unused variable 'oldValue' in nsMathMLmpaddedFrame::UpdateValue

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

In nsMathMLmpaddedFrame::UpdateValue, the variable oldValue became unused after

http://hg.mozilla.org/mozilla-central/rev/b28932f43641

and should be removed.

Comment 1

[Nigel Babu [:nigelb]]

Attachment: remove oldvalue

Attached patch removes the line

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Nigel, if you can attach a patch generated as explained on <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>, we can get it checked in for you.

Comment 3

[Nigel Babu [:nigelb]]

Attachment: remove-oldvalue

Patch in the right format for check-in

Comment 4

[Nigel Babu [:nigelb]]

Attachment: rename-oldvalue v3

v3 of the patch with reviewer's name in the commit

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks! Landed on inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/691c76a1a455

Someone will probably merge it over to mozilla-central later today (for some value of "today").

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/691c76a1a455

Comment 7

[Ed Morley [:emorley]]

Thanks Nigel, one step closer for bug 187528 :-)