Last Comment Bug 672444 - warning: unused variable 'oldValue' in nsMathMLmpaddedFrame::UpdateValue
: warning: unused variable 'oldValue' in nsMathMLmpaddedFrame::UpdateValue
[good first bug]
: helpwanted
Product: Core
Classification: Components
Component: MathML (show other bugs)
: Trunk
: All All
-- trivial (vote)
: mozilla8
Assigned To: Nigel Babu [:nigelb]
: Anthony Jones (:kentuckyfriedtakahe, :k17e)
Depends on:
Blocks: buildwarning mpadded-voffset
  Show dependency treegraph
Reported: 2011-07-18 22:35 PDT by Frédéric Wang (:fredw)
Modified: 2011-08-01 07:48 PDT (History)
6 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

remove oldvalue (796 bytes, patch)
2011-07-24 09:29 PDT, Nigel Babu [:nigelb]
karlt: review+
Details | Diff | Splinter Review
remove-oldvalue (921 bytes, patch)
2011-07-29 05:13 PDT, Nigel Babu [:nigelb]
no flags Details | Diff | Splinter Review
rename-oldvalue v3 (930 bytes, patch)
2011-07-29 05:15 PDT, Nigel Babu [:nigelb]
no flags Details | Diff | Splinter Review

Description User image Frédéric Wang (:fredw) 2011-07-18 22:35:37 PDT
In nsMathMLmpaddedFrame::UpdateValue, the variable oldValue became unused after

and should be removed.
Comment 1 User image Nigel Babu [:nigelb] 2011-07-24 09:29:24 PDT
Created attachment 548021 [details] [diff] [review]
remove oldvalue

Attached patch removes the line
Comment 2 User image :Ms2ger (⌚ UTC+1/+2) 2011-07-29 02:42:49 PDT
Nigel, if you can attach a patch generated as explained on <>, we can get it checked in for you.
Comment 3 User image Nigel Babu [:nigelb] 2011-07-29 05:13:05 PDT
Created attachment 549344 [details] [diff] [review]

Patch in the right format for check-in
Comment 4 User image Nigel Babu [:nigelb] 2011-07-29 05:15:30 PDT
Created attachment 549345 [details] [diff] [review]
rename-oldvalue v3

v3 of the patch with reviewer's name in the commit
Comment 5 User image :Ms2ger (⌚ UTC+1/+2) 2011-07-29 05:41:52 PDT
Thanks! Landed on inbound:

Someone will probably merge it over to mozilla-central later today (for some value of "today").
Comment 6 User image Marco Bonardo [::mak] 2011-08-01 07:46:04 PDT
Comment 7 User image Ed Morley [:emorley] 2011-08-01 07:48:04 PDT
Thanks Nigel, one step closer for bug 187528 :-)

Note You need to log in before you can comment on or make changes to this bug.