Last Comment Bug 672450 - C4233/C4267 warning for jsobj.h, vm/String.h and jsatom.h
: C4233/C4267 warning for jsobj.h, vm/String.h and jsatom.h
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Windows Vista
: -- normal (vote)
: mozilla8
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-18 23:38 PDT by Makoto Kato [:m_kato]
Modified: 2011-07-20 07:00 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (2.00 KB, patch)
2011-07-18 23:40 PDT, Makoto Kato [:m_kato]
luke: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2011-07-18 23:38:45 PDT
there is a lot of warning when including js header.

C:\Workspace\hg.mozilla.org\mozilla-win64\js\src\jsobj.h(597) : warning C4244: 'return' : conversion from 'const jsuword' to 'uint32', possible loss of data
c:\workspace\hg.mozilla.org\mozilla-win64\js\src\vm/String.h(586) : warning C4267: 'return' : conversion from 'size_t' to 'intN', possible loss of data
c:\workspace\hg.mozilla.org\mozilla-win64\js\src\jsatom.h(118) : warning C4267: 'return' : conversion from 'size_t' to 'js::HashNumber', possible loss of data
Comment 1 Makoto Kato [:m_kato] 2011-07-18 23:40:08 PDT
Created attachment 546720 [details] [diff] [review]
fix
Comment 3 Marco Bonardo [::mak] 2011-07-20 07:00:16 PDT
http://hg.mozilla.org/mozilla-central/rev/b2e3241c7f04

Note You need to log in before you can comment on or make changes to this bug.