Closed Bug 672511 Opened 8 years ago Closed 8 years ago

Morph nsIAccessNode::uniqueId

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: surkov, Assigned: atulagrwl)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [bk1])

Attachments

(1 file, 2 obsolete files)

I realize uniqueId can be interesting for automated testing so it makes sense to keep it. But then it should be scriptable. We could cast void* to int to workaround it.
(In reply to comment #0)
> I realize uniqueId can be interesting for automated testing so it makes
> sense to keep it. But then it should be scriptable. We could cast void* to

do we want to use it in our tests? or who do  we expect to be writing tests that want this?

> int to workaround it.

that won't work on 64 bbit platforms.   since all current machines have atmost a 48 bit virtual address psace afaik we ight be able to use a double, I'm not sure if there will be any colisions or not.  Otherwise I suppose we could return 2 ints.
(In reply to comment #1)
> (In reply to comment #0)
> > I realize uniqueId can be interesting for automated testing so it makes
> > sense to keep it. But then it should be scriptable. We could cast void* to
> 
> do we want to use it in our tests? or who do  we expect to be writing tests
> that want this?

Yes, in out tests.

> > int to workaround it.
> 
> that won't work on 64 bbit platforms.   since all current machines have
> atmost a 48 bit virtual address psace afaik we ight be able to use a double,
> I'm not sure if there will be any colisions or not.  Otherwise I suppose we
> could return 2 ints.

MSAA expects for 32bit, when we do this then int works.
Ok, it's worth to remove this method at all. Internal part use address as ID, MSAA likely will have own implementation. No tests as far as we have. If we need it then it can be added later.
So we want to remove the method right? Good first bug?
Whiteboard: [bk1]
(In reply to David Bolter [:davidb] from comment #4)
> So we want to remove the method right? Good first bug?

yes, if we are agree on comment #3.
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → atulagrwl
Attachment #577470 - Flags: review?(peterv)
Comment on attachment 577470 [details] [diff] [review]
Patch v1

Review of attachment 577470 [details] [diff] [review]:
-----------------------------------------------------------------

you should bump interface uuid, r=me
Attachment #577470 - Flags: review?(peterv) → review+
Attached patch Patch v1.01 (obsolete) — Splinter Review
Attachment #577470 - Attachment is obsolete: true
Attached patch Patch v1.02Splinter Review
Attachment #577888 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cacd0273ca21
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.