Closed
Bug 672519
Opened 13 years ago
Closed 13 years ago
Incorrect vertical alignment of tspan inside dominant-baseline
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: Martin.vGagern, Assigned: longsonr)
References
Details
(Whiteboard: [inbound])
Attachments
(2 files, 1 obsolete file)
566 bytes,
image/svg+xml
|
Details | |
2.67 KB,
patch
|
Details | Diff | Splinter Review |
The attached file does not render as I'd have expected in FF 5. <text dominant-baseline="central"> <tspan>foo </tspan> <tspan>bar </tspan> <tspan>baz</tspan> </text> I'd have expected all three tspans to be aligned along the same "central" baseline. But for reasons unknon, it appears that each tspan except the first has its "central" baseline aligned to the "alphabetic" baseline of its predecessor. Makes vertical centering a real problem.
Comment 1•13 years ago
|
||
Agreed, I think the test should show all three tspans aligned on their central baseline.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•13 years ago
|
||
Assignee: nobody → longsonr
Attachment #547106 -
Flags: review?(jwatt)
Assignee | ||
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Version: 5 Branch → Trunk
Assignee | ||
Updated•13 years ago
|
Attachment #547106 -
Flags: review?(jwatt) → review?(dholbert)
Comment 3•13 years ago
|
||
Comment on attachment 547106 [details] [diff] [review] hg changeset patch with test >+++ b/layout/reftests/svg/reftest.list >@@ -204,6 +204,7 @@ fails-if(Android) random-if(gtk2Widget) > == text-layout-02.svg text-layout-02-ref.svg > == text-layout-03.svg text-layout-03-ref.svg > == text-layout-04.svg text-layout-04-ref.svg >+== text-layout-05.svg pass.svg [...] >+++ b/layout/reftests/svg/text-layout-05.svg [...] >+ <text x="20" y="200" dominant-baseline="central" >+ font-family="monospace" font-size="50px"><tspan>foo </tspan><tspan>bar </tspan><tspan>baz</tspan></text> >+ <!-- cover where we expect the text to be --> >+ <rect x="20" y="178" width="330" height="40" fill="lime"/> I think we could test this much more robustly if we just compared against a reference that has the <tspan>'s removed. (i.e. just using a <text> node in the reference case) Could you change the test (or add another test) that does that? r=me with that
Attachment #547106 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 4•13 years ago
|
||
I was expecting this not to work due to subpixel positioning differences but I seem to be wrong. http://tbpl.mozilla.org/?tree=Try&rev=8c780666adab
Attachment #547106 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Whiteboard: [inbound]
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite+
Assignee | ||
Comment 5•13 years ago
|
||
pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/7b25f48cc21b
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7b25f48cc21b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•