672561 - "awDocumentKeyPress is not defined" when opening Mailing List dialog [New List]

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Error:
awDocumentKeyPress is not defined
chrome://messenger/content/addressbook/abMailListDialog.js
Line: 245

TB has a corresponding function here:
http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/addressingWidgetOverlay.js#1049

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

This should probably go into Aurora then, too.

Comment 2

[[e-mail]]

We removed this from the compose window in bug 603101 because it was buggy, but we forgot to check for shared uses in mailnews :-(

Can you also make it call awRecipientKeyPress, so we get the nice up/down behaviour as well as shift+tab? (Sadly the version of awTabFromRecipient in abMailListDialog.js is buggy so we don't get the right tab behaviour. Any idea how (or if) Thunderbird handles this?)

[Ideally we would nuke awDocumentKeyPress and use handleKeyPress instead.]

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v1a [Checkin: comments 6 and 8]

(In reply to [e-mail] from comment #2)
> Can you also make it call awRecipientKeyPress, so we get the nice up/down
> behaviour as well as shift+tab?

I can confirm that using awRecipientKeyPress gives us up/down arrow key support, which is indeed nice, but I also have Shift+Tab working without this patch at all, so what do you mean there (see also next point)?

> (Sadly the version of awTabFromRecipient in
> abMailListDialog.js is buggy so we don't get the right tab behaviour. Any
> idea how (or if) Thunderbird handles this?)

First I'd have to understand what the "right" tab behavior is in your eyes. AFAICS TB behaves like us without the patch.

Comment 4

[[e-mail]]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #3)
> First I'd have to understand what the "right" tab behavior is in your eyes.
The "right" tab behaviour is what you get in the Compose window, where "tab" cycles through all the addresses, even when they have scrolled out of view.

Comment 5

[[e-mail]]

Comment on attachment 551893 [details] [diff] [review]
patch v1a [Checkin: comments 6 and 8]

Well, I guess the tab handling is consistent this way, so better than v1.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 551893 [details] [diff] [review]
patch v1a [Checkin: comments 6 and 8]

http://hg.mozilla.org/comm-central/rev/551872168f3a

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 551893 [details] [diff] [review]
patch v1a [Checkin: comments 6 and 8]

This gets rid of an error message and allows using the arrow keys in the Mailing List dialog (again?). Should be safe enough for Aurora so it'll be in 2.4.

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 551893 [details] [diff] [review]
patch v1a [Checkin: comments 6 and 8]

http://hg.mozilla.org/releases/comm-aurora/rev/ab422cc8f58c