Closed Bug 672563 Opened 9 years ago Closed 9 years ago

Back out bug 663251 so we run the profiling step only once on Linux

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla8

People

(Reporter: justin.lebar+bug, Unassigned)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

In bug 663251, we modified profile.py so it accepts a number N and runs the profiling step for the build N times.  Later, we checked in a build-config change setting N to 10 on Linux.

The hope was that this would improve our benchmark scores (in particular, that it would decrease the variance in the scores).  This did not appear to happen when we checked in the build-config change.

Some time after we checked in this change, however, we did see a decrease in scores' variance.  (See bug 653961 comment 87.)

So it appears that one of two things happened.  Either

 * running the profiling step multiple times had no effect on benchmark scores, or
 * the build-config change didn't take effect immediately, for some reason.

I'd like to know, both to make progress on the mystery that is bug 653961 comment 87, and so we don't run the profiled build 10 times on Linux if we don't need to.

As far as I can tell, the only way to know for sure would be to back out bug 663251's changes to profile.py and see how that affects benchmark scores on m-i and m-c.  Tryserver has been shown not to be useful for this investigation, since I saw there performance increases which haven't manifested since, even after the mysterious change in bug 653961 comment 87.

Similarly, I think we should back out specifically the changes to profile.py, rather than the changes to the build-config, because I have more confidence that the profile.py change will take effect immediately.
Attachment #546827 - Flags: review?(ted.mielczarek)
Comment on attachment 546827 [details] [diff] [review]
Backout v1, takes us back to dc8d154f3710

Whatever you want to do is fine with me.
Attachment #546827 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/4b96a9cd9b15
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.