Closed Bug 672583 Opened 10 years ago Closed 10 years ago

MacLaunchHandler.cc incorrectly uses NS_ARRAY_LENGTH on a pointer

Categories

(Core Graveyard :: Embedding: Mac, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla8

People

(Reporter: jdm, Assigned: jdm)

Details

Attachments

(1 file)

>87   cpu_type_t *wanted_type = pref_cpu_types;
>88 
>89   if (aRestartType & nsIAppStartup::eRestarti386)
>90     wanted_type = cpu_i386_types;
>91   else if (aRestartType & nsIAppStartup::eRestartx86_64)
>92     wanted_type = cpu_x64_86_types;
>93 
>94   // Set spawn attributes.
>95   size_t attr_count = NS_ARRAY_LENGTH(wanted_type);
Attachment #546844 - Flags: review?(joshmoz)
Attachment #546844 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/ca526e2c233a
Assignee: nobody → josh
Whiteboard: [inbound]
We should use a template to ensure that NS_ARRAY_LENGTH is only used on an array.
Coincidentally, I have a patch that does that, which is what found this instance.
http://hg.mozilla.org/mozilla-central/rev/ca526e2c233a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.