Closed
Bug 672583
Opened 14 years ago
Closed 14 years ago
MacLaunchHandler.cc incorrectly uses NS_ARRAY_LENGTH on a pointer
Categories
(Core Graveyard :: Embedding: Mac, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: jdm, Assigned: jdm)
Details
Attachments
(1 file)
|
1.51 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
>87 cpu_type_t *wanted_type = pref_cpu_types;
>88
>89 if (aRestartType & nsIAppStartup::eRestarti386)
>90 wanted_type = cpu_i386_types;
>91 else if (aRestartType & nsIAppStartup::eRestartx86_64)
>92 wanted_type = cpu_x64_86_types;
>93
>94 // Set spawn attributes.
>95 size_t attr_count = NS_ARRAY_LENGTH(wanted_type);
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #546844 -
Flags: review?(joshmoz)
Attachment #546844 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: nobody → josh
Whiteboard: [inbound]
We should use a template to ensure that NS_ARRAY_LENGTH is only used on an array.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Coincidentally, I have a patch that does that, which is what found this instance.
Nice.
|
||
Comment 6•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•