MacLaunchHandler.cc incorrectly uses NS_ARRAY_LENGTH on a pointer

RESOLVED FIXED in mozilla8

Status

Core Graveyard
Embedding: Mac
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

unspecified
mozilla8
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
>87   cpu_type_t *wanted_type = pref_cpu_types;
>88 
>89   if (aRestartType & nsIAppStartup::eRestarti386)
>90     wanted_type = cpu_i386_types;
>91   else if (aRestartType & nsIAppStartup::eRestartx86_64)
>92     wanted_type = cpu_x64_86_types;
>93 
>94   // Set spawn attributes.
>95   size_t attr_count = NS_ARRAY_LENGTH(wanted_type);
(Assignee)

Comment 1

6 years ago
Created attachment 546844 [details] [diff] [review]
Avoid calling NS_ARRAY_LENGTH on a pointer.
Attachment #546844 - Flags: review?(joshmoz)

Updated

6 years ago
Attachment #546844 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/ca526e2c233a
Assignee: nobody → josh
Whiteboard: [inbound]
We should use a template to ensure that NS_ARRAY_LENGTH is only used on an array.
(Assignee)

Comment 4

6 years ago
Coincidentally, I have a patch that does that, which is what found this instance.
Nice.
http://hg.mozilla.org/mozilla-central/rev/ca526e2c233a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.