Open Bug 672618 Opened 10 years ago Updated 4 months ago
I think this is sufficient, but I don't particularly have time to look into tests at the moment.
Comment on attachment 546891 [details] [diff] [review] patch Asking for review (Dao, feel free to reassign, but I figure you know this area best) and ui-review (ohai, Alex!) Also asking for feedback from bz (who is wise in the way of loading documents and such) and Jesse (who is wise in the way of security and how this might intersect with it, though I struggle to see that as an issue)
Comment on attachment 546891 [details] [diff] [review] patch I have been accused of patch stealing; my bad. Mostly wanted to get the ui team's opinion.
Seems like a reasonable thing to do until we can fix bug 55696. Bug 151142 and bug 251137 may be related. Bug 138198 is the SeaMonkey equivalent. Comments on the patch: * It might be good for the comment to explain why we're doing this (by referring to bug 55696 and/or bug 335963). * Please don't parse protocols out of URLs using regexps. * We should make sure the patch does the right thing for middle-clicks.
Comment on attachment 546891 [details] [diff] [review] patch yep, better than a useless tab
Attachment #546891 - Flags: ui-review+
(In reply to comment #4) > * Please don't parse protocols out of URLs using regexps. Generally I would agree with this, but there's no scriptable way to access the link's existing underlying nsIURI, as far as I know, and creating another nsIURI manually just to parse the scheme is unnecessary overhead - the .href return value is nsIURI.spec, so we don't need to deal with arbitrary values, and this particular check isn't critical to get 100% right.
No longer blocks: fxdesktopbacklog
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Component: General → DOM: Core & HTML
Product: Firefox → Core
Flags: needinfo?(bzbarsky) → needinfo?(bugs)
You need to log in before you can comment on or make changes to this bug.