67281 - Pref: networking.cookie.* should not be in network

Status: VERIFIED WONTFIX

(Core :: Networking: Cookies, defect)

Description

[timeless]

reason: they get timeless in trouble.
see #mozilla snipet:
[timeless] can anyone here blame me for putting network.cookie.* into a 
network.js file?
<jag> yes
conclusion:
[timeless]   then the cookies shouldn't be named network.*
<jag> I totally agree :-)

Comment 1

[timeless]

i'll attach a patch that replaces network.cookie.* with cookie.*

Comment 2

[timeless]

Attachment: remove network. from cookie. pref strings

Comment 3

[Stephen P. Morse]

1. You also need to make the correction in the _elementIDs of 
pref-cookies.xul.

2. While you are doing this, you should also fix up the following two prefs.  
They are the image-manager equivalent of the two prefs you are fixing.

   network.image.imageBehavior
   network.image.warnAboutImages

If you make these two corrections, then r=morse

Comment 4

[Marek Z. Jeziorek]

* proposing Mozilla0.9 as the target milestone
* adding embed keyword

Comment 5

[Marek Z. Jeziorek]

Mozilla 0.8 builds started today. We would consider taking reviewed low risk 
fixes if they are available today (Wednesday, 7/Feb/01) or tomorrow (Thursday, 
8/Feb/01). Otherwise, please set the target milestone to Mozilla 0.9. Thanks.

Comment 6

[Gervase Markham [:gerv]]

Attachment: Patch to fix cookie and image prefs

Comment 7

[Gervase Markham [:gerv]]

morse: Could you have a look at this new patch, please?

timeless: hope you don't mind me taking this :-)

Gerv

Comment 8

[Stephen P. Morse]

I'm confused by this patch for the following reasons:

1. Patch includes obsolete file
    xpfe/components/prefwindow/resources/content/Attic/pref-cookies.xul

2. Patch does not include the current version of that file
    extensions/cookie/resources/content/pref-cookies.xul

3. For images patch does include the correct file
    extensions/cookie/resources/content/pref-images.xul
   but it does not fix the occurence of "network" in var _elementIDs

Comment 9

[Gervase Markham [:gerv]]

1 and 2: My tree is out of date, it would seem.

3: I messed up.

I'll sort it :-)

Gerv

Comment 10

[timeless]

wouldn't cookie.behavior be better? [yes i do have this sitting in my tree, 
it's rotting w/ other cleanup]

Comment 11

[Gervase Markham [:gerv]]

That's not very clear... sadly, the pref is the wrong way round to call it
cookie.accept - how about cookie.reject ? 0 = Accept, 1 = NotForeign, 2=
RejectAll (I assume.)

Gerv

Comment 12

[Stephen P. Morse]

How about cookie.behavior.  It's not a boolean so why try to name it as if it 
were?

Comment 13

[Gervase Markham [:gerv]]

It just seems too vague. Changing cookie.cookieBehavior to cookie.behavior
doesn't seem like much of an improvement. How about cookie.rejectPolicy ? Or
cookie.acceptPolicy?

Gerv

Comment 14

[Gervase Markham [:gerv]]

On second thoughts, I don't care enough for it to keep this out of 0.9.1.
cookie.behavior (and image.behavior) it is.

Gerv

Comment 15

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Comment 16

[Gervase Markham [:gerv]]

morse: Could you possibly have a look at this new attempt? Thanks :-)

Gerv

Comment 17

[Stephen P. Morse]

r=morse

Comment 18

[Gervase Markham [:gerv]]

No sr= before tree close; unless morse disagrees and says this is important, I'm 
pushing it out to 0.9.2.

Gerv

Comment 19

[Stephen P. Morse]

You won't hear any disagreement from me.  Personally I think this is completely 
unimportant.

Comment 20

[Brendan Eich [:brendan]]

cookieBehavior : warnAboutCookies :: imageBehavior : imageWarnAboutImages ?

Oops -- shouldn't the last be named warnAboutImages?

/be

Comment 21

[Gervase Markham [:gerv]]

Discussion moved to n.p.m.18n and n.p.m.ui.

Gerv

Comment 22

[Gervase Markham [:gerv]]

Attachment: Patch v.2 - fixes brendan's nit

Comment 23

[Stephen P. Morse]

r=morse for nit-picking fix.

Comment 24

[Alec Flett]

so what do you do about users who already have these prefs set? the image
blocking thing is one thing, but the cookies thing is compeletely different - a
user could have been using an earlier version (or migrated from a Netscape 4.x 
browser) who had cookies disabled - suddenly they download 0.9.2 and their
browser is accepting cookies again, without them knowing it. 

I'm personally wondering if this should be WONTFIX.

Comment 25

[Gervase Markham [:gerv]]

If they were using a pre-release, that's their lookout. If they are upgrading 
from 4.x, I'm sure there's some pref name translating mechanism. If not, there 
should be. Who should I be seeing about profile migration issues?

We cannot say "once a pref name is established, it never changes" - that's a 
massive recipe for cruft in the prefs system. We are going to need some names to 
change at some point, particularly if we write an "advanced pref editor" which 
presents them in the form of a tree.

Hmm.

Gerv

Comment 26

[Alec Flett]

you need to look in profile/pref-migrator and see how prefs are migrated from
4.x.. once you figure out what to add there, you need to land that change in
addition to the ones here.

Comment 27

[Gervase Markham [:gerv]]

I'm not going to get to this in the next 7 days.

Gerv

Comment 28

[Gervase Markham [:gerv]]

timeless: if this involves migration-fu, is it still worth doing?

Gerv

Comment 29

[timeless]

probably, besides you need to learn migration foo for bookmarks :-).

Comment 30

[Gervase Markham [:gerv]]

Well, then you'll need to point me at some docs or a knowledgeable person
because I can't make head or tail of it. I would have though there'd be a simple
text file: old name -> new name - but there doesn't seem to be.

Gerv

Comment 31

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tomorrow night.
Pushing out a milestone.  Please correct if I'm mistaken.

Comment 32

[Stephen P. Morse]

After seeing this again, I have second thoughts and am withdrawing my r= from 
these patches.

On the surface, this seems like a good thing to do for the sake of cleanliness.  
But it will break all existing user profiles.  Any user who upgrades his 6.01 
browser to 6.1 will lose all his saved cookie preferences.

Comment 33

[Gervase Markham [:gerv]]

timeless - feel free to WONTFIX this, or fix it with migration-fu.

Gerv

Comment 34

[Judson Valeski]

now that cookies are headed to their new home in the necko module, I wonder if
this bug becomes invalid?

Comment 35

[timeless]

interesting point.

Comment 36

[Judson Valeski]

minusing for topembed. I supsect this is actually invalid.

Comment 37

[Juan José Mata]

Bug 62755 was just made topembed+, can we take a look at this one and see if it
still warrants to be made invalid or need a fix?  Making this one topembed+
since it blocks 62755 on paper.

Comment 38

[benc]

recommend WONTFIX. Bug 210561 means this probably belongs wher it is.

Comment 39

[Benjamin Smedberg]

reopen this if you disagree, but this looks WONTFIX to me...

Comment 40

[[e-mail]]

indeed, thanks bsmedberg!

Comment 41

[benc]

V. Thanks.