672817 - site-by-site last downloaded-to directory is not always remembered

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[James [silentj]]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110720 Firefox/8.0a1
Build ID: 20110720030844

Steps to reproduce:

create a new profile 

change: options:general:downloads to: 'always ask me where to save files'

open http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

click on firefox-8.0a1.en-US.linux-i686.complete.mar file

click save file

create a new folder on your desktop 'moz' 

click save

open http://winscp.net/eng/download.php in another tab

click installation package

when the 'opening' dialogue appears click save file

create another folder on your desktop 'winscp'

click save

go back to the ftp.mozilla.org tab 

click on firefox-8.0a1.en-US.linux-x86_64.complete.mar

click save file


Actual results:

the pre-selected folder for the download is 'winscp'



Expected results:

folder should be last used folder for ftp.mozilla.org - 'moz'

note that if you use right click and 'save link as' on the download links on each tab the last downloaded-to folder is remember per site as expected

Comment 1

[Stefan]

Confirm both of your observations. 

BTW: Since when does Fx recall the directory on a per-site basis? 

I want the old behavior back: There is a single, current, persistent and changeable download directory for all downloads. Is this configurable?

Comment 2

[:aceman]

It is since Firefox 7 and implemented in bug 536503.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: patch

When saving a file through the unknown content-type dialog, the current code can't find a URI to save the directory for.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 568009 [details] [diff] [review]
patch

The aLauncher null check seems unnecessary, are there actually cases when it could be null?

It would be nice to understand which cases are covered by the aContext case. Is it even needed at all? When would source be null?

Comment 5

[Geoff Lankow (:darktrojan)]

Hmmm. According to MXR, the only point aLauncher is null is during a test. I'll figure out how to fix it.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: patch v2

I wish I'd understood this stuff better when I wrote the original bug. :-/

Comment 7

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70be30dd2082

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/70be30dd2082

Comment 9

[Marcelo Bastos]

Stefan (Comment 1): A pref to turn back to the old behavior is being created on bug 702748