GCLI needs to provide completion hints for Javascript to match the JSTerms hints

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [best:2d, likely:4d, worst:7d])

Comment hidden (empty)
Blocks: 659059

Comment 1

6 years ago
Just making a note that depending on how things are implemented, we might want this bug to fix bug 672733
Depends on: 672733
Good spot, thanks.
Blocks: 675923
No longer blocks: 659059
Mihai is doing e10s work on the JS completion. I hope we can use this as the basis for JS completion in GCLI.
Ideally the e10s work would extract the completion logic into a separate JSM with a well defined API, which should help us re-use it in a CommonJS module.

CCing Mihai.
There's e10s work underway that allows marshaling of objects and their properties for the Property Panel, in bug 673148.

That work is very much reusable for the existing autocomplete code and for the upcoming GCLI autocomplete work that needs to be done.

Once I get back to work on the e10s patch in 673148 I will implement a sort of GC for the evaluated content objects, and I will also move to making the existing autocomplete code work with the new e10s-friendly API.

Once that's done I believe you can do the work needed here. (if it is desired that this bug is fixed in an e10s friendly approach from the start.)
Marking as minotaur, and adding estimates
Whiteboard: [minotaur][best:d, likely:4d, worst:5d]
Should add - the estimates are guestimates.
Whiteboard: [minotaur][best:d, likely:4d, worst:5d] → [minotaur][best:2d, likely:4d, worst:7d]
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
No longer depends on: 672733
Whiteboard: [minotaur][best:2d, likely:4d, worst:7d] → [best:2d, likely:4d, worst:7d]
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.