Last Comment Bug 672939 - fennec package name repeats itself with NDKr5 and greater
: fennec package name repeats itself with NDKr5 and greater
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla8
Assigned To: Nobody; OK to take it and work on it
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 657723 712275
  Show dependency treegraph
 
Reported: 2011-07-20 13:51 PDT by Brad Lassey [:blassey] (use needinfo?)
Modified: 2011-12-20 05:59 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.08 KB, patch)
2011-07-20 13:51 PDT, Brad Lassey [:blassey] (use needinfo?)
khuey: review+
Details | Diff | Splinter Review

Description Brad Lassey [:blassey] (use needinfo?) 2011-07-20 13:51:24 PDT
Created attachment 547229 [details] [diff] [review]
patch

with NDKr4 our package name is "fennec-8.0a1.en-US.eabi-arm.apk", currently that changes to "fennec-8.0a1.en-US.arm-linuxandroid-arm-linuxandroid.apk" with NDKr5 and newer. This patch fixes that to be "fennec-8.0a1.en-US.android-arm.apk"

The core problem is the vendor and os weren't separated by a - in config.sub so we couldn't extract its components properly. So in autoconfig.mk we had something like this:
TARGET_CPU      = arm-linuxandroid
TARGET_VENDOR   = arm-linuxandroid
TARGET_OS       = arm-linuxandroid

with this patch, that turns into:
TARGET_CPU      = arm
TARGET_VENDOR   = linux
TARGET_OS       = android


which seems more sane to me.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-20 13:56:18 PDT
Comment on attachment 547229 [details] [diff] [review]
patch

Sounds good to me, but you should add this to js/src/ctypes/libffi.patch so that we don't accidentally blow away that bit in the future.
Comment 2 Marco Bonardo [::mak] 2011-07-21 06:14:41 PDT
http://hg.mozilla.org/mozilla-central/rev/cdec5871f47b

Note You need to log in before you can comment on or make changes to this bug.