Closed Bug 672939 Opened 10 years ago Closed 10 years ago
fennec package name repeats itself with NDKr5 and greater
with NDKr4 our package name is "fennec-8.0a1.en-US.eabi-arm.apk", currently that changes to "fennec-8.0a1.en-US.arm-linuxandroid-arm-linuxandroid.apk" with NDKr5 and newer. This patch fixes that to be "fennec-8.0a1.en-US.android-arm.apk" The core problem is the vendor and os weren't separated by a - in config.sub so we couldn't extract its components properly. So in autoconfig.mk we had something like this: TARGET_CPU = arm-linuxandroid TARGET_VENDOR = arm-linuxandroid TARGET_OS = arm-linuxandroid with this patch, that turns into: TARGET_CPU = arm TARGET_VENDOR = linux TARGET_OS = android which seems more sane to me.
Attachment #547229 - Flags: review?(khuey)
Comment on attachment 547229 [details] [diff] [review] patch Sounds good to me, but you should add this to js/src/ctypes/libffi.patch so that we don't accidentally blow away that bit in the future.
Attachment #547229 - Flags: review?(khuey) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.