67296 - [FIX]Printing selection: borders outside selection are printed

Status: REOPENED

(Core :: Printing: Output, defect, P3)

Description

[Tobias Burnus]

This is 2001-01-31-21/Linux

Goto the URL and mark e.g. the first line.

All links which use "border-bottom:" are printed (dotted and dashed lines all
over the page). Moreover: If I only select one word of the <h1> title on that
page, I get a huge blue frame (of the multiline <h1>) and all other frame
backgrounds print too.

(This is the print to ps output, not X11/Xprt)

Comment 1

[dcone (gone)]

This is for you Rod

Comment 2

[rods (gone)]

I have a fix for the dotted border problem

Comment 3

[rods (gone)]

Attachment: patch file

Comment 4

[rods (gone)]

Attachment: better patch

Comment 5

[Marc Attinasi]

Some comments:

nsBlockFrame::IsVisibleForPainting - the if(aCheckVis) block needs to set
aIsVisible when TRUE too, like maybe '*aIsVisible = disp->IsVisible(); return
NS_OK;' Same thing in nsFrame version, actually, since that block is identical
in both (that block could be factored, but whatever, not really worth it).

Personally, I'd prefer if GetSelectionforVisCheck returned an nsresult and had
an inout param for the nsISelection* - then you could propagate the error from
selcon->GetSelection (assuming that there is one, otherwise that API is probably
masking the error and it should be commented as such). And the 'for' shoudld
probably be capitalized, as in GetSelectionForVisCheck(...).

Meditate on those comments and you get the coveted 'sr=attinasi', grasshopper.

Comment 6

[Kevin McCluskey (gone)]

patch 25930 looks good.
r=[e-mail]

Comment 7

[Kevin McCluskey (gone)]

Setting milestone to mozilla0.8.1

Comment 8

[rods (gone)]

fixed

Comment 9

[Tobias Burnus]

With Mozilla 0.9 I still get the effect that I get dotted borders with the URL 
file. (Those are inline borders of <accr> and <abbr>, <span>;
from CSS: border-bottom: 1pt dotted rgb(40%,40%,40%);)

Note that those borders are in paragraphs which are *not* selected!

(Note further that the border of frames [of <p> etc.] which are only partly 
selected print full size. It would look better if the frame hight would be as 
high as if this paragraph (etc.) whouldn't contain more lines.)

If needed be I can attach a ps file (or a gif of the ps file or ...)

Comment 10

[Christopher Hoess (gone)]

Changing milestone.

Comment 11

[rods (gone)]

The problem is the nsHTMLContainer::Paint needs to do an IsVisibleForPainting 
but it can't because then nothing gets painted. So it needs to check to see if 
the frame is a span or whether the content an acronym or abbr.

The span approach is far more generic, but I am unsure of all the case where it 
will kick in. The content specific cases for acronym and abbr works well but 
might miss some other cases.

I have tested both approaches, Approach #1:

      // check to see if container is an acronym or abbr
      PRBool isVisible = PR_TRUE;
      if (mContent) {
        nsCOMPtr<nsIAtom> tag;
        mContent->GetTag(*getter_AddRefs(tag));
        if (tag.get() == nsHTMLAtoms::acronym || tag.get() == nsHTMLAtoms::abbr) 
{
          if (NS_FAILED(IsVisibleForPainting(aPresContext, aRenderingContext, 
PR_FALSE, &isVisible))) {
            isVisible = PR_TRUE;
          }
        }
      }

Approach #2:
      // check to see if container is span
      PRBool isVisible = PR_TRUE;
      nsCOMPtr<nsIAtom> frameType;
      GetFrameType(getter_AddRefs(frameType));
      if (frameType.get() == nsLayoutAtoms::inlineFrame) {
        if (NS_FAILED(IsVisibleForPainting(aPresContext, aRenderingContext, 
PR_FALSE, &isVisible))) {
          isVisible = PR_TRUE;
        }
      }

Comment 12

[Max Alekseyev]

Related bug 180637

Comment 13

[Aakash Desai [:aakashd]]

Why is this bug still in an assigned state ?

Comment 14

[:Hb]

Eight years old, duplicating against current bug.

Comment 15

[Daniel Holbert [:dholbert]]

At least superficially, this doesn't look at all like a dupe of bug 428111, as I noted in bug 428111 comment 7.  Un-marking as dupe.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information