Closed Bug 673026 Opened 13 years ago Closed 13 years ago

IonMonkey: Phis are not inserted in some branch conditions

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: adrake, Assigned: dvander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In test case:

function branchy(v0,v1) {
 var result = 0;
 if (v0 & v1) {
  result = v0 & v0;
 } else {
  result = v1 & v0;
 }
 return result;
}
branchy(379,1)

no phis are inserted, but at least one should be inserted on the return.

The first bad revision is:
changeset:   72960:c7f8e17bc91c
user:        David Anderson <danderson@mozilla.com>
date:        Mon Jul 18 17:43:09 2011 -0700
summary:     Remove snapshots from IR, attach to nodes directly (bug 669984 part 4, r=adrake).
Attached patch fixSplinter Review
This broke because snapshots stopped placing an implicit first instruction in the block, so we need a new way to test whether the block has had its first predecessor set.
Assignee: general → dvander
Status: NEW → ASSIGNED
Attachment #547603 - Flags: review?(adrake)
Attachment #547603 - Flags: review?(adrake) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/7605afbb47bb
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.