Closed
Bug 673144
Opened 14 years ago
Closed 14 years ago
Passing more information on BackendError
Categories
(Cloud Services :: Server: Registration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tarek, Assigned: tarek)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
8.22 KB,
patch
|
telliott
:
review+
rmiller
:
review+
|
Details | Diff | Splinter Review |
File "/usr/lib/python2.6/site-packages/services/auth/mozilla_sreg.py", line 182, in delete_user
raise BackendError()
=> this need to pass the initial error
e.g. BackendError(str(error))
Assignee | ||
Comment 1•14 years ago
|
||
We need
- the initial TB
- the back end server where the error happened
Summary: Passing the error when delete user fails → Passing more information on BackendError
Assignee | ||
Comment 2•14 years ago
|
||
from the meeting we had on the topic:
- BackendError will have a few optionals args:
- retry_after
- server
- base_app gets a get_infos() that is dumped in the error log
get_infos() returns stuff like user info, and other app can complete/override it
Assignee | ||
Comment 3•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #547827 -
Flags: review?(rmiller)
Comment 5•14 years ago
|
||
Comment on attachment 547827 [details] [diff] [review]
Adds the features discussed
Review of attachment 547827 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #547827 -
Flags: review?(rmiller) → review+
Updated•14 years ago
|
Attachment #547827 -
Flags: review?(telliott) → review+
Comment 6•14 years ago
|
||
Comment on attachment 547827 [details] [diff] [review]
Adds the features discussed
Driveby feedback:
>- except BackendError:
>- err = traceback.format_exc()
>- hash = create_hash(err)
>+ except BackendError, err:
I recommend the Python 3.x syntax which is already available in Python 2.6:
except BackendError as err
which is way more readable than the broken 2.x syntax.
Assignee | ||
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•