Status
()
People
(Reporter: david.volgyes, Assigned: kinetik)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 2 obsolete attachments)
|
4.05 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
Created attachment 547436 [details] [diff] [review] patch with my proposed solution User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0 Build ID: 20110622232440 Steps to reproduce: I tested the code with cppcheck 1.49, and I checked some warning from the result. Actual results: Cppcheck showed several warnings, but some of them false positive. This seems a real bug: content/media/webm/nsWebMReader.cpp:498]: (error) Memory leak: buffer The code allocates memory for temporary storage. However, it does not release the memory when error happens. Expected results: - Memory should be released before "return". (A possible fix is attached, but please, review it before use.) - Mozilla should use cppcheck for automated testing.
|
||
Updated•8 years ago
|
Component: General → Video/Audio
Product: Firefox → Core
QA Contact: general → video.audio
|
||
Comment 1•8 years ago
|
||
Nice catch! Please make |buffer| an nsAutoArrayPtr<SoundDataValue>, so that it's automatically released on scope exit instead. You'll need to call buffer.forget() when you pass it to the SoundData constructor, as that takes over ownership.
|
(Assignee) | |
Comment 2•8 years ago
|
||
Created attachment 549287 [details] [diff] [review] patch v0
Assignee: nobody → kinetik
Attachment #547436 -
Attachment is obsolete: true
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #549287 -
Flags: review?(chris)
|
|
(Assignee) | |
Comment 3•8 years ago
|
||
Comment on attachment 549287 [details] [diff] [review] patch v0 Oops, this is missing a buffer.forget() in once place.
Attachment #549287 -
Flags: review?(chris)
|
|
(Assignee) | |
Comment 4•8 years ago
|
||
Created attachment 549288 [details] [diff] [review] patch v1
Attachment #549287 -
Attachment is obsolete: true
Attachment #549288 -
Flags: review?(chris)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 549288 [details] [diff] [review] patch v1 Review of attachment 549288 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #549288 -
Flags: review?(chris) → review+
|
|
(Assignee) | |
Updated•8 years ago
|
Whiteboard: [inbound]
|
||
Comment 6•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a7260d755392
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•