Closed
Bug 673214
Opened 14 years ago
Closed 14 years ago
nanojit.h should probably include njcpudetect.h
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stejohns, Assigned: wmaddox)
Details
(Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit,[inbound])
Attachments
(1 file)
|
525 bytes,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Stan Switzer (Adobe) suggests: "It is right and fitting for nanojit to include its own headers rather than relying on [cpp files] to do so for it."
|
Reporter | |
Comment 1•14 years ago
|
||
Attachment #547492 -
Flags: review?(nnethercote)
|
|
||
Comment 2•14 years ago
|
||
changeset: 6482:13252f5bae23
user: Steven Johnson <stejohns@adobe.com>
summary: Bug 673214 - nanojit.h should probably include njcpudetect.h (r=pending)
http://hg.mozilla.org/tamarin-redux/rev/13252f5bae23
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 547492 [details] [diff] [review]
Patch
Review of attachment 547492 [details] [diff] [review]:
-----------------------------------------------------------------
The usual process is to wait for r+ before landing the patch ;)
Attachment #547492 -
Flags: review?(nnethercote) → review+
|
|
Reporter | |
Comment 4•14 years ago
|
||
Agreed, in this case I landed it in tamarin-redux as a stopgap measure to get the build unstuck -- I was prepared to back it out again if you didn't like this fix :-)
|
Assignee | |
Comment 5•14 years ago
|
||
|
|
||
Comment 6•14 years ago
|
||
changeset: 6526:c8c41390d4a3
user: William Maddox <wmaddox@adobe.com>
summary: Bug 673214 - nanojit.h should probably include njcpudetect.h [stejohns@adobe.com] (r=nnethercote)
http://hg.mozilla.org/tamarin-redux/rev/c8c41390d4a3
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → wmaddox
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit
|
||
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•14 years ago
|
||
Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit → fixed-in-tamarin-redux,fixed-in-nanojit,[inbound]
|
||
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•