The default bug view has changed. See this FAQ.

nanojit.h should probably include njcpudetect.h

RESOLVED FIXED

Status

Core Graveyard
Nanojit
--
minor
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: Steven Johnson, Assigned: William Maddox)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit,[inbound])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Stan Switzer (Adobe) suggests: "It is right and fitting for nanojit to include its own headers rather than relying on [cpp files] to do so for it."
(Reporter)

Comment 1

6 years ago
Created attachment 547492 [details] [diff] [review]
Patch
Attachment #547492 - Flags: review?(nnethercote)

Comment 2

6 years ago
changeset: 6482:13252f5bae23
user:      Steven Johnson <stejohns@adobe.com>
summary:   Bug 673214 - nanojit.h should probably include njcpudetect.h (r=pending)

http://hg.mozilla.org/tamarin-redux/rev/13252f5bae23
Comment on attachment 547492 [details] [diff] [review]
Patch

Review of attachment 547492 [details] [diff] [review]:
-----------------------------------------------------------------

The usual process is to wait for r+ before landing the patch ;)
Attachment #547492 - Flags: review?(nnethercote) → review+
(Reporter)

Comment 4

6 years ago
Agreed, in this case I landed it in tamarin-redux as a stopgap measure to get the build unstuck -- I was prepared to back it out again if you didn't like this fix :-)
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/projects/nanojit-central/rev/fc5941cc395e

Comment 6

6 years ago
changeset: 6526:c8c41390d4a3
user:      William Maddox <wmaddox@adobe.com>
summary:   Bug 673214 - nanojit.h should probably include njcpudetect.h [stejohns@adobe.com] (r=nnethercote)

http://hg.mozilla.org/tamarin-redux/rev/c8c41390d4a3
(Assignee)

Updated

6 years ago
Assignee: nobody → wmaddox
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit
http://hg.mozilla.org/mozilla-central/rev/78c8c065bc95
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
http://hg.mozilla.org/integration/mozilla-inbound/rev/78c8c065bc95
Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit → fixed-in-tamarin-redux,fixed-in-nanojit,[inbound]
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.