Closed Bug 673214 Opened 12 years ago Closed 12 years ago

nanojit.h should probably include njcpudetect.h

Categories

(Core Graveyard :: Nanojit, defect)

Product:
Core Graveyard
Component:
Nanojit
Platform:
ARM
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stejohns, Assigned: wmaddox)

Details

(Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit,[inbound])

Attachments

(1 file)

Patch
525 bytes, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
Stan Switzer (Adobe) suggests: "It is right and fitting for nanojit to include its own headers rather than relying on [cpp files] to do so for it."
Attached patch Patch — — Splinter Review 

        Attachment #547492 -
        Flags: review?(nnethercote)

    
    

    
  
changeset: 6482:13252f5bae23
user:      Steven Johnson <stejohns@adobe.com>
summary:   Bug 673214 - nanojit.h should probably include njcpudetect.h (r=pending)

http://hg.mozilla.org/tamarin-redux/rev/13252f5bae23

    
    

    
  
Comment on attachment 547492 [details] [diff] [review]
Patch

Review of attachment 547492 [details] [diff] [review]:
-----------------------------------------------------------------

The usual process is to wait for r+ before landing the patch ;)

        Attachment #547492 -
        Flags: review?(nnethercote) → review+

    
    

    
  
Agreed, in this case I landed it in tamarin-redux as a stopgap measure to get the build unstuck -- I was prepared to back it out again if you didn't like this fix :-)

    
    

    
  
changeset: 6526:c8c41390d4a3
user:      William Maddox <wmaddox@adobe.com>
summary:   Bug 673214 - nanojit.h should probably include njcpudetect.h [stejohns@adobe.com] (r=nnethercote)

http://hg.mozilla.org/tamarin-redux/rev/c8c41390d4a3

    
  
Assignee: nobody → wmaddox
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/78c8c065bc95
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  
http://hg.mozilla.org/integration/mozilla-inbound/rev/78c8c065bc95
Whiteboard: fixed-in-tamarin-redux,fixed-in-nanojit → fixed-in-tamarin-redux,fixed-in-nanojit,[inbound]
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.