Investigate speeding up docshell/test/navigation/test_sessionhistory.html

RESOLVED FIXED in mozilla9

Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgriffin, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
As part of the BuildFaster project (see https://wiki.mozilla.org/ReleaseEngineering/BuildFaster), we are investigating whether certain slow mochitests can be sped up.

test_sessionhistory.html is a slow test, average execution time on a recent run (in ms):

	win32-debug, 46186
	linux-opt, 28182
	macosx64-debug, 51978
	win32-opt, 28260
	linux64-debug, 44187
	linux64-opt, 28247
	macosx64-opt, 28796
	macosx-debug, 48526
	linux-debug, 45130
(Reporter)

Comment 1

6 years ago
Olli, as the original test author, would you be willing to help see if this test can be sped up?
Well, 7s or so is the 1000ms timeouts from nextTest().  I wonder why we need those....  Also some of the subtests have 1000ms timeouts.

Past that, this is actually tests for 7 bugs in 1....  I wonder whether any particular subtests are slow here.
(Reporter)

Comment 3

6 years ago
Created attachment 553582 [details] [diff] [review]
mochitest patch

This patch removes the 1s timeouts.  It passed on try.  Do you think it's safe to land?
Attachment #553582 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #553582 - Flags: review?(Olli.Pettay) → review+
(Reporter)

Comment 4

6 years ago
Landed as http://hg.mozilla.org/integration/mozilla-inbound/rev/cc68eeea347f
http://hg.mozilla.org/mozilla-central/rev/cc68eeea347f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Updated

6 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.