673285 - Investigate speeding up docshell/test/navigation/test_sessionhistory.html

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jonathan Griffin (:jgriffin)]

As part of the BuildFaster project (see https://wiki.mozilla.org/ReleaseEngineering/BuildFaster), we are investigating whether certain slow mochitests can be sped up.

test_sessionhistory.html is a slow test, average execution time on a recent run (in ms):

	win32-debug, 46186
	linux-opt, 28182
	macosx64-debug, 51978
	win32-opt, 28260
	linux64-debug, 44187
	linux64-opt, 28247
	macosx64-opt, 28796
	macosx-debug, 48526
	linux-debug, 45130

Comment 1

[Jonathan Griffin (:jgriffin)]

Olli, as the original test author, would you be willing to help see if this test can be sped up?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Well, 7s or so is the 1000ms timeouts from nextTest().  I wonder why we need those....  Also some of the subtests have 1000ms timeouts.

Past that, this is actually tests for 7 bugs in 1....  I wonder whether any particular subtests are slow here.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: mochitest patch

This patch removes the 1s timeouts.  It passed on try.  Do you think it's safe to land?

Comment 4

[Jonathan Griffin (:jgriffin)]

Landed as http://hg.mozilla.org/integration/mozilla-inbound/rev/cc68eeea347f

Comment 5

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/cc68eeea347f