Closed Bug 673285 Opened 9 years ago Closed 9 years ago

Investigate speeding up docshell/test/navigation/test_sessionhistory.html

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: jgriffin, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of the BuildFaster project (see https://wiki.mozilla.org/ReleaseEngineering/BuildFaster), we are investigating whether certain slow mochitests can be sped up.

test_sessionhistory.html is a slow test, average execution time on a recent run (in ms):

	win32-debug, 46186
	linux-opt, 28182
	macosx64-debug, 51978
	win32-opt, 28260
	linux64-debug, 44187
	linux64-opt, 28247
	macosx64-opt, 28796
	macosx-debug, 48526
	linux-debug, 45130
Olli, as the original test author, would you be willing to help see if this test can be sped up?
Well, 7s or so is the 1000ms timeouts from nextTest().  I wonder why we need those....  Also some of the subtests have 1000ms timeouts.

Past that, this is actually tests for 7 bugs in 1....  I wonder whether any particular subtests are slow here.
Attached patch mochitest patchSplinter Review
This patch removes the 1s timeouts.  It passed on try.  Do you think it's safe to land?
Attachment #553582 - Flags: review?(Olli.Pettay)
Attachment #553582 - Flags: review?(Olli.Pettay) → review+
http://hg.mozilla.org/mozilla-central/rev/cc68eeea347f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.