Status
()
People
(Reporter: rnewman, Assigned: gps)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [prune][good first bug][qa-])
Attachments
(1 attachment, 1 obsolete attachment)
|
4.31 KB,
patch
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Assignee) | |
Comment 1•7 years ago
|
||
Created attachment 548954 [details] [diff] [review] const cleanup part 1 Patch to clean up file mode constants (now using FileUtils). Also deletes 1 unused constant (WEAVE_ID). I have not finished auditing all the constants, so additional patches likely.
Attachment #548954 -
Flags: review?(philipp)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 548954 [details] [diff] [review] const cleanup part 1 > Cu.import("resource://services-sync/util.js"); > Cu.import("resource://services-sync/constants.js"); >+Cu.import("resource://gre/modules/FileUtils.jsm"); util.js already exposes FileUtils so this isn't technically needed.
Attachment #548954 -
Flags: review?(philipp) → review+
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
Created attachment 548989 [details] [diff] [review] const cleanup part 1 Updated patch message to reflect review.
Attachment #548954 -
Attachment is obsolete: true
|
|
(Assignee) | |
Updated•7 years ago
|
||
Keywords: checkin-needed
|
(Reporter) | |
Comment 4•7 years ago
|
||
Part 1: http://hg.mozilla.org/services/services-central/rev/cd4551dae071 Treating this as a one-part bug (e.g., "fixed in services") for now. We can file followups if you find more.
Keywords: checkin-needed
Whiteboard: [prune][good first bug] → [prune][good first bug][fixed in services][qa-]
|
|
||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd4551dae071
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [prune][good first bug][fixed in services][qa-] → [prune][good first bug][qa-]
Target Milestone: --- → mozilla8
|
||
Updated•2 months ago
|
||
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.