Closed
Bug 673288
Opened 10 years ago
Closed 10 years ago
Prune: remove dead constants from Sync
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: rnewman, Assigned: gps)
Details
(Whiteboard: [prune][good first bug][qa-])
Attachments
(1 file, 1 obsolete file)
4.31 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Patch to clean up file mode constants (now using FileUtils). Also deletes 1 unused constant (WEAVE_ID). I have not finished auditing all the constants, so additional patches likely.
Attachment #548954 -
Flags: review?(philipp)
Comment 2•10 years ago
|
||
Comment on attachment 548954 [details] [diff] [review] const cleanup part 1 > Cu.import("resource://services-sync/util.js"); > Cu.import("resource://services-sync/constants.js"); >+Cu.import("resource://gre/modules/FileUtils.jsm"); util.js already exposes FileUtils so this isn't technically needed.
Attachment #548954 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Updated patch message to reflect review.
Attachment #548954 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 4•10 years ago
|
||
Part 1: http://hg.mozilla.org/services/services-central/rev/cd4551dae071 Treating this as a one-part bug (e.g., "fixed in services") for now. We can file followups if you find more.
Keywords: checkin-needed
Whiteboard: [prune][good first bug] → [prune][good first bug][fixed in services][qa-]
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd4551dae071
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [prune][good first bug][fixed in services][qa-] → [prune][good first bug][qa-]
Target Milestone: --- → mozilla8
Updated•3 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•