Closed Bug 673288 Opened 10 years ago Closed 10 years ago
Prune: remove dead constants from Sync
No description provided.
Patch to clean up file mode constants (now using FileUtils). Also deletes 1 unused constant (WEAVE_ID). I have not finished auditing all the constants, so additional patches likely.
Attachment #548954 - Flags: review?(philipp)
Comment on attachment 548954 [details] [diff] [review] const cleanup part 1 > Cu.import("resource://services-sync/util.js"); > Cu.import("resource://services-sync/constants.js"); >+Cu.import("resource://gre/modules/FileUtils.jsm"); util.js already exposes FileUtils so this isn't technically needed.
Attachment #548954 - Flags: review?(philipp) → review+
Updated patch message to reflect review.
Attachment #548954 - Attachment is obsolete: true
Part 1: http://hg.mozilla.org/services/services-central/rev/cd4551dae071 Treating this as a one-part bug (e.g., "fixed in services") for now. We can file followups if you find more.
Whiteboard: [prune][good first bug] → [prune][good first bug][fixed in services][qa-]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [prune][good first bug][fixed in services][qa-] → [prune][good first bug][qa-]
Target Milestone: --- → mozilla8
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.