Last Comment Bug 673461 - ANGLE needs to stop automagically turning itself off in configure if the DirectX SDK is not found
: ANGLE needs to stop automagically turning itself off in configure if the Dire...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86 Windows 7
: -- normal (vote)
: mozilla8
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com)
:
Mentors:
Depends on:
Blocks: 716381
  Show dependency treegraph
 
Reported: 2011-07-22 10:33 PDT by Kyle Huey [:khuey] (khuey@mozilla.com)
Modified: 2012-01-08 09:17 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.94 KB, patch)
2011-07-22 10:48 PDT, Kyle Huey [:khuey] (khuey@mozilla.com)
ted: review+
Details | Diff | Review

Description Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-22 10:33:32 PDT

    
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-22 10:48:25 PDT
Created attachment 547741 [details] [diff] [review]
Patch
Comment 2 Ted Mielczarek [:ted.mielczarek] 2011-07-22 12:23:53 PDT
Comment on attachment 547741 [details] [diff] [review]
Patch

Review of attachment 547741 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-23 18:43:46 PDT
http://hg.mozilla.org/mozilla-central/rev/ad1655c2e5b1
Comment 4 Joe Drew (not getting mail) 2011-07-24 17:59:18 PDT
Don't we fail to build without the DX SDK? We definitely don't want to accidentally release without it installed.
Comment 5 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-07-24 18:01:11 PDT
(In reply to comment #4)
> Don't we fail to build without the DX SDK? We definitely don't want to
> accidentally release without it installed.

We did not fail before, now we do.
Comment 6 Joe Drew (not getting mail) 2011-07-24 18:02:59 PDT
ohai im dumb

Note You need to log in before you can comment on or make changes to this bug.