Closed
Bug 673612
Opened 13 years ago
Closed 13 years ago
JS shell does not show help for profiling functions
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: sfink, Assigned: sfink)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file)
2.34 KB,
patch
|
cdleary
:
review+
|
Details | Diff | Splinter Review |
help() in the JS shell only prints out the help for the functions defined directly in shell/js.cpp, not all the help messages that are defined.
Attachment #547842 -
Flags: review?(cdleary)
Comment 1•13 years ago
|
||
Comment on attachment 547842 [details] [diff] [review] Recover the missing help messages Review of attachment 547842 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/shell/js.cpp @@ +5100,5 @@ > > fprintf(gOutFile, "%s\n", JS_GetImplementationVersion()); > if (argc == 0) { > fputs(shell_help_header, gOutFile); > + for (i = 0; i < (sizeof(shell_help_messages) / sizeof(shell_help_messages[0])); ++i) JS_ARRAY_SIZE macro does exactly this, IIRC. @@ +5123,3 @@ > return JS_FALSE; > + for (j = 0; j < (sizeof(shell_help_messages) / sizeof(shell_help_messages[0])); ++j) > + { Ditto on the limit, brace on same line?
Attachment #547842 -
Flags: review?(cdleary) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Fixed nits, thanks. (JS_ARRAY_LENGTH, btw.) http://hg.mozilla.org/integration/mozilla-inbound/rev/97cc7ab517e0
Whiteboard: [inbound]
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/97cc7ab517e0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Updated•13 years ago
|
Assignee: general → sphink
You need to log in
before you can comment on or make changes to this bug.
Description
•