--enable-callgrind should turn on --enable-profiling

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sfink, Unassigned)

Tracking

unspecified
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Created attachment 547856 [details] [diff] [review]
--enable-callgrind turns on --enable-profiling

--enable-profiling means, as far as I can tell, "add commands to appropriate global objects that allow controlling profiling" (so start/stop/pause/resume/etc.)

Many profiler-like things don't really need that sort of thing, but Callgrind must be explicitly started (AFAICT; I haven't actually used it). So it makes little sense to use --enable-callgrind without --enable-profiling.

Other profiling options already enable --enable-profiling, too, so this isn't a first.

(nb: I made this patch to work around another problem which I have correctly resolved in other ways, so if there's some reason to not do this, then it's not going to break anything. For example, if we decide to --enable-callgrind by default, it would widen the attack surface very slightly to also --enable-profiling.)
Attachment #547856 - Flags: review?(dmandelin)
Comment on attachment 547856 [details] [diff] [review]
--enable-callgrind turns on --enable-profiling

Review of attachment 547856 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #547856 - Flags: review?(dmandelin) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/e50f838bea83
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/e50f838bea83
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.