673627 - --enable-callgrind should turn on --enable-profiling

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Attachment: --enable-callgrind turns on --enable-profiling

--enable-profiling means, as far as I can tell, "add commands to appropriate global objects that allow controlling profiling" (so start/stop/pause/resume/etc.)

Many profiler-like things don't really need that sort of thing, but Callgrind must be explicitly started (AFAICT; I haven't actually used it). So it makes little sense to use --enable-callgrind without --enable-profiling.

Other profiling options already enable --enable-profiling, too, so this isn't a first.

(nb: I made this patch to work around another problem which I have correctly resolved in other ways, so if there's some reason to not do this, then it's not going to break anything. For example, if we decide to --enable-callgrind by default, it would widen the attack surface very slightly to also --enable-profiling.)

Comment 1

[David Mandelin [:dmandelin]]

Comment on attachment 547856 [details] [diff] [review]
--enable-callgrind turns on --enable-profiling

Review of attachment 547856 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 2

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e50f838bea83

Comment 3

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/e50f838bea83