Closed
Bug 673647
Opened 15 years ago
Closed 15 years ago
Make it more obvious which bits in JSObject::flags are up for grabs
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: Waldo, Assigned: Waldo)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
1.92 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
...a disadvantage of a flag field over bit fields.
I tentatively plan to use a couple flag bits to distinguish different kinds of element property storage, and the way the flag enums are described now -- including that there's a random hole in the described bits -- is not particularly clear.
This passes shell tests, JIT tests, and JSAPI tests on my system.
Attachment #547881 -
Flags: review?(dvander)
|
||
Updated•15 years ago
|
Attachment #547881 -
Flags: review?(dvander) → review+
|
Assignee | |
Comment 1•15 years ago
|
||
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
|
||
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•