Last Comment Bug 673647 - Make it more obvious which bits in JSObject::flags are up for grabs
: Make it more obvious which bits in JSObject::flags are up for grabs
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: mozilla8
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-22 19:28 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-07-27 03:44 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.92 KB, patch)
2011-07-22 19:28 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
dvander: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-07-22 19:28:25 PDT
Created attachment 547881 [details] [diff] [review]
Patch

...a disadvantage of a flag field over bit fields.

I tentatively plan to use a couple flag bits to distinguish different kinds of element property storage, and the way the flag enums are described now -- including that there's a random hole in the described bits -- is not particularly clear.

This passes shell tests, JIT tests, and JSAPI tests on my system.
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2011-07-26 17:37:47 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/b6937b8ba51b
Comment 2 Marco Bonardo [::mak] 2011-07-27 03:44:24 PDT
http://hg.mozilla.org/mozilla-central/rev/b6937b8ba51b

Note You need to log in before you can comment on or make changes to this bug.