Fennec freezes when viewing a non .txt file from disk

VERIFIED FIXED in Firefox 7

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: glandium, Assigned: dougt)

Tracking

({verified-aurora})

Trunk
Firefox 7
ARM
Android
verified-aurora

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
(This may be related to bug 661978)

- Go to about:sync-log
- Tap on one of the .log files
- Fennec freezes

(tested on a nightly)

I think the same problem may happen for different file types read from other file:///... directory listings (which about:sync-log is, now)

Comment 1

6 years ago
I can reproduce this on Nexus S, 2.3.4.  tapping a log file in about:sync-log will freeze phone, and then throw the force quit activity dialog.  

Working on getting a logcat

Comment 2

6 years ago
Created attachment 548253 [details]
force quit logcat
(Reporter)

Updated

6 years ago
Attachment #548253 - Attachment mime type: text/rtf → text/plain
I'm seeing this too, although I remember it used to work when I first landed bug 610832. I wonder if bug 673309 has fixed it (it renamed .log to .txt).
Blocks: 610832
Confirmed. Fennec nightly lockup clicking log file. Files stored on SD card.
Sync annoyance indeed resolved by Bug 673309. Fennec bug still remains, so let's leave this open.
Thanks for verifying, Tony. Indeed an underlying Fennec issue, presumably with '.log' files. Changing the summary accordingly.
Summary: Fennec freezes when opening sync log file → Fennec freezes when a .log file from disk
Tony, can you confirm that Fennec Aurora is also affected? If so, we should probably land bug 673309 there too to cover for the underlying Fennec issue.
I t looks like we try to open the *.log files using nsMimeInfo::LaunchWithFile on desktop and android. Desktop works, opening in the a text editor. Android seems to fail, maybe it is not finding an app (intent) that can open log files.
(In reply to comment #8)
> I t looks like we try to open the *.log files using
> nsMimeInfo::LaunchWithFile on desktop and android. Desktop works, opening in
> the a text editor.

Except in most cases .log files (much like .txt files) end up being opened by Firefox itself. (Bug 671911 is an exception that we haven't been able to reproduce.)

> Android seems to fail, maybe it is not finding an app
> (intent) that can open log files.

Either that, or it hangs trying to delegate the intent. Failing explicitly with an error message would be better than hanging.
Summary: Fennec freezes when a .log file from disk → Fennec freezes when opening a .log file from disk
(In reply to comment #7)
> Tony, can you confirm that Fennec Aurora is also affected? If so, we should
> probably land bug 673309 there too to cover for the underlying Fennec issue.

note to self to check this.
(Assignee)

Comment 11

6 years ago
couple of problems.  I am glad that we are going to use .txt for the log files, but that doesn't fix the underlying android's problem.  It looks like nsMIMEInfoAndroid needs some love.  we probably should start caching requests to java.  I'll do that work here.
Assignee: nobody → doug.turner
Summary: Fennec freezes when opening a .log file from disk → Fennec freezes when a .log file from disk
I was able to open the log file, after long tapping on it, and then saving it to the doc folder.  I was not able to open it from where it resides normally.  

file:///data/data/org.mozilla.fennec/files/mozilla/<profileid>.default/weave/logs/
changing title to non .txt files, as file handler also locks up on other types (.json)
Summary: Fennec freezes when a .log file from disk → Fennec freezes when viewing a non .txt file from disk
(In reply to comment #10)
> (In reply to comment #7)
> > Tony, can you confirm that Fennec Aurora is also affected? If so, we should
> > probably land bug 673309 there too to cover for the underlying Fennec issue.
> 
> note to self to check this.

and yes, it happens on aurora and nighty also.
(Assignee)

Comment 15

6 years ago
tony, yup.  many file extensions lock things up.
(Assignee)

Comment 16

6 years ago
Created attachment 548699 [details] [diff] [review]
patch v.1
Attachment #548699 - Flags: review?(blassey.bugs)
Comment on attachment 548699 [details] [diff] [review]
patch v.1

Review of attachment 548699 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #548699 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 18

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/38e2e8f4b0b2
tracking-fennec: --- → ?
http://hg.mozilla.org/mozilla-central/rev/38e2e8f4b0b2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110728 Firefox/8.0a1 Fennec/8.0a1
Status: RESOLVED → VERIFIED
Comment on attachment 548699 [details] [diff] [review]
patch v.1

Per LegNeato's comment on Bug 673309, nominating this for Aurora.
Attachment #548699 - Flags: approval-mozilla-aurora?

Comment 22

6 years ago
Comment on attachment 548699 [details] [diff] [review]
patch v.1

Approved for releases/mozilla-aurora
Attachment #548699 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed to mozilla-aurora:

  http://hg.mozilla.org/releases/mozilla-aurora/rev/4b51e77c121a

/me thinks about which flags to set...
status-firefox7: --- → fixed
Target Milestone: Firefox 8 → Firefox 7
Verified Fixed on Aurora

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a2) Gecko/20110803 Firefox/7.0a2 Fennec/7.0a2
Keywords: verified-aurora
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.