673741 - Snoozing one alarm on an item with multiple alarms causes other alarms to fire early

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Matthew Mecca [:mmecca]]

STR:
1) Create an event and set several alarms before the start time
2) Wait for the first alarm to fire, snooze it for 1 minute

Results:
One minute later the other alarms for the event fire at once.

This can be compounded if the preference to show missed alarms is not set, and the first snoozed alarm is missed, which causes the other future alarms not to fire at all.

Comment 1

[Matthew Mecca [:mmecca]]

Attachment: Fix v1

Adds a check to use the snooze date only if it is later than the original alarm date. Since we can't snooze an alarm backwards, an earlier snooze date must be from an earlier alarm, and shouldn't affect future alarms.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 550493 [details] [diff] [review]
Fix v1

Looks reasonable. Feel free to push to central/aurora/beta. r=philipp

Comment 3

[Stefan Sitter [:ssitter]]

Matthew, do you need assistance for checkin?

Comment 4

[Matthew Mecca [:mmecca]]

(In reply to Stefan Sitter from comment #3)
> Matthew, do you need assistance for checkin?

I'm just waiting on my repository account setup, but if someone else wants to check this in in the mean time that's fine.

Comment 5

[Matthew Mecca [:mmecca]]

Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/19d0c31327d1

Comment 6

[Matthew Mecca [:mmecca]]

Pushed to comm-aurora - http://hg.mozilla.org/releases/comm-aurora/rev/b59fbda1674f

Comment 7

[Matthew Mecca [:mmecca]]

If there are no objections, I don't think we should take this on comm-beta this close to release.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Matthew Mecca [:mmecca] from comment #7)
> If there are no objections, I don't think we should take this on comm-beta
> this close to release.

Totally fine, no objections from me :) Congrats on your first checkin(s)!