Closed Bug 673741 Opened 9 years ago Closed 9 years ago

Snoozing one alarm on an item with multiple alarms causes other alarms to fire early

Categories

(Calendar :: Alarms, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mmecca, Assigned: mmecca)

Details

Attachments

(1 file)

STR:
1) Create an event and set several alarms before the start time
2) Wait for the first alarm to fire, snooze it for 1 minute

Results:
One minute later the other alarms for the event fire at once.

This can be compounded if the preference to show missed alarms is not set, and the first snoozed alarm is missed, which causes the other future alarms not to fire at all.
Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
OS: Linux → All
Attached patch Fix v1Splinter Review
Adds a check to use the snooze date only if it is later than the original alarm date. Since we can't snooze an alarm backwards, an earlier snooze date must be from an earlier alarm, and shouldn't affect future alarms.
Attachment #550493 - Flags: review?(philipp)
Comment on attachment 550493 [details] [diff] [review]
Fix v1

Looks reasonable. Feel free to push to central/aurora/beta. r=philipp
Attachment #550493 - Flags: review?(philipp) → review+
Matthew, do you need assistance for checkin?
(In reply to Stefan Sitter from comment #3)
> Matthew, do you need assistance for checkin?

I'm just waiting on my repository account setup, but if someone else wants to check this in in the mean time that's fine.
Target Milestone: --- → 1.0b7
If there are no objections, I don't think we should take this on comm-beta this close to release.
Target Milestone: 1.0b7 → 1.0b8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to Matthew Mecca [:mmecca] from comment #7)
> If there are no objections, I don't think we should take this on comm-beta
> this close to release.

Totally fine, no objections from me :) Congrats on your first checkin(s)!
You need to log in before you can comment on or make changes to this bug.