Closed
Bug 673789
Opened 12 years ago
Closed 12 years ago
minidump_generator.cc uses mach/ppc/thread_status.h unconditionally
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: espindola, Assigned: espindola)
Details
(Whiteboard: fixed-in-bs)
Attachments
(1 file, 2 obsolete files)
4.84 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
mach/ppc/thread_status.h has been removed from the 10.7 sdk. We should add an ifdef for it or just drop it if no breakpad user supports ppc anymore.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → respindola
Assignee | ||
Comment 1•12 years ago
|
||
Let me know if I should add a configure check instead.
Attachment #548028 -
Flags: review?(ted.mielczarek)
Comment 2•12 years ago
|
||
Comment on attachment 548028 [details] [diff] [review] drop support for ppc I don't think we're going to drop support for PPC upstream, so we'll probably want to #ifdef this. Something like MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_7 ? Also, if you could generate this against upstream Breakpad SVN that would be helpful for me: http://code.google.com/p/google-breakpad/source/checkout
Attachment #548028 -
Flags: review?(ted.mielczarek) → review-
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #548028 -
Attachment is obsolete: true
Attachment #548354 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #548354 -
Attachment is obsolete: true
Attachment #548354 -
Flags: review?(ted.mielczarek)
Attachment #548355 -
Flags: review?(ted.mielczarek)
Comment 5•12 years ago
|
||
Comment on attachment 548355 [details] [diff] [review] define HAS_PPC_SUPPORT in the right place Review of attachment 548355 [details] [diff] [review]: ----------------------------------------------------------------- Okay, this looks good. I'll land it upstream for you.
Attachment #548355 -
Flags: review?(ted.mielczarek) → review+
Comment 6•12 years ago
|
||
Landed in Breakpad SVN: http://code.google.com/p/google-breakpad/source/detail?r=817
Assignee | ||
Comment 7•12 years ago
|
||
Thanks! Should we backport or just update breakpad?
Comment 8•12 years ago
|
||
We can land your patch in mozilla-central as well, I still have a few more patches to upstream before we can update our Breakpad snapshot.
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 9•12 years ago
|
||
http://hg.mozilla.org/projects/build-system/rev/3a7ad3683fbf
Keywords: checkin-needed
Whiteboard: fixed-in-bs
Comment 10•12 years ago
|
||
>+#ifdef HAS_PPC_SUUPORT
> case CPU_TYPE_POWERPC:
> return WriteStackPPC(state, stack_location);
> case CPU_TYPE_POWERPC64:
> return WriteStackPPC64(state, stack_location);
>+#endif
Looks like there is typo in patch. s/SUUPORT/SUPPORT
Comment 11•12 years ago
|
||
Thanks, I pushed a fix for that upstream: http://code.google.com/p/google-breakpad/source/detail?r=820
http://hg.mozilla.org/mozilla-central/rev/3a7ad3683fbf
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•