minidump_generator.cc uses mach/ppc/thread_status.h unconditionally

RESOLVED FIXED in mozilla8

Status

()

Toolkit
Breakpad Integration
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla8
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment, 2 obsolete attachments)

mach/ppc/thread_status.h has been removed from the 10.7 sdk. We should add an ifdef for it or just drop it if no breakpad user supports ppc anymore.
Assignee: nobody → respindola
Created attachment 548028 [details] [diff] [review]
drop support for ppc

Let me know if I should add a configure check instead.
Attachment #548028 - Flags: review?(ted.mielczarek)
Comment on attachment 548028 [details] [diff] [review]
drop support for ppc

I don't think we're going to drop support for PPC upstream, so we'll probably want to #ifdef this. Something like MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_7 ?

Also, if you could generate this against upstream Breakpad SVN that would be helpful for me:
http://code.google.com/p/google-breakpad/source/checkout
Attachment #548028 - Flags: review?(ted.mielczarek) → review-
Created attachment 548354 [details] [diff] [review]
Only use ppc on mac os < 10.7
Attachment #548028 - Attachment is obsolete: true
Attachment #548354 - Flags: review?(ted.mielczarek)
Created attachment 548355 [details] [diff] [review]
define HAS_PPC_SUPPORT in the right place
Attachment #548354 - Attachment is obsolete: true
Attachment #548354 - Flags: review?(ted.mielczarek)
Attachment #548355 - Flags: review?(ted.mielczarek)
Comment on attachment 548355 [details] [diff] [review]
define HAS_PPC_SUPPORT in the right place

Review of attachment 548355 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, this looks good. I'll land it upstream for you.
Attachment #548355 - Flags: review?(ted.mielczarek) → review+
Landed in Breakpad SVN:
http://code.google.com/p/google-breakpad/source/detail?r=817
Thanks!
Should we backport or just update breakpad?
We can land your patch in mozilla-central as well, I still have a few more patches to upstream before we can update our Breakpad snapshot.
Keywords: checkin-needed
http://hg.mozilla.org/projects/build-system/rev/3a7ad3683fbf
Keywords: checkin-needed
Whiteboard: fixed-in-bs
>+#ifdef HAS_PPC_SUUPORT
>     case CPU_TYPE_POWERPC:
>       return WriteStackPPC(state, stack_location);
>     case CPU_TYPE_POWERPC64:
>       return WriteStackPPC64(state, stack_location);
>+#endif

Looks like there is typo in patch. s/SUUPORT/SUPPORT
Thanks, I pushed a fix for that upstream:
http://code.google.com/p/google-breakpad/source/detail?r=820
http://hg.mozilla.org/mozilla-central/rev/3a7ad3683fbf
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.