The default bug view has changed. See this FAQ.

(TypeInference)Fix TI for Solaris x86

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-jaegermonkey)

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Update TrampolineSUNWX86.s and TrampolineSUNWX64.s, also deal with no fastcall situation with Solaris Studio on x86.
(Assignee)

Comment 1

6 years ago
Created attachment 548111 [details] [diff] [review]
patch

The Solaris x64 version is blindly updated since JS/Solaris x64 is blocked by another issue.
Assignee: general → ginn.chen
Status: NEW → ASSIGNED
Attachment #548111 - Flags: review?(bhackett1024)
Comment on attachment 548111 [details] [diff] [review]
patch

Review of attachment 548111 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinfer.cpp
@@ +72,5 @@
>  #endif
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Why is this necessary?  Is there a better place to do this include?

::: js/src/jsobj.cpp
@@ +109,5 @@
>  #include "jsautooplen.h"
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Ditto.
Attachment #548111 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 3

6 years ago
<alloca.h> is required for alloca() with Solaris Studio compiler.
alloca() is used in DEBUG section in jsinfer.cpp.

alloca() is not used in jsobj.cpp now, so these lines are no longer needed for jsobj.cpp.
(Assignee)

Comment 4

6 years ago
Created attachment 548666 [details] [diff] [review]
patch to commit

I've no permission to jaegermonkey.
(Assignee)

Comment 5

6 years ago
Looks like I have no write permission to any repo now, filed Bug 674451.

Comment 6

6 years ago
http://hg.mozilla.org/projects/jaegermonkey/rev/c7a7d9ff99da
Whiteboard: fixed-in-jaegermonkey
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/mozilla-central/rev/c7a7d9ff99da
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.