Comment 1 Ginn Chen 2011-07-25 00:16:23 PDT

Created attachment 548111 [details] [diff] [review]
patch

The Solaris x64 version is blindly updated since JS/Solaris x64 is blocked by another issue.

Comment 2 Brian Hackett (:bhackett) 2011-07-25 06:22:53 PDT

Comment on attachment 548111 [details] [diff] [review]
patch

Review of attachment 548111 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinfer.cpp
@@ +72,5 @@
>  #endif
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Why is this necessary?  Is there a better place to do this include?

::: js/src/jsobj.cpp
@@ +109,5 @@
>  #include "jsautooplen.h"
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Ditto.

Comment 3 Ginn Chen 2011-07-26 00:18:55 PDT

<alloca.h> is required for alloca() with Solaris Studio compiler.
alloca() is used in DEBUG section in jsinfer.cpp.

alloca() is not used in jsobj.cpp now, so these lines are no longer needed for jsobj.cpp.

Comment 4 Ginn Chen 2011-07-26 19:46:29 PDT

Created attachment 548666 [details] [diff] [review]
patch to commit

I've no permission to jaegermonkey.

Comment 5 Ginn Chen 2011-07-26 21:15:37 PDT

Looks like I have no write permission to any repo now, filed Bug 674451.

Comment 6 Leon Sha 2011-07-27 18:26:47 PDT

http://hg.mozilla.org/projects/jaegermonkey/rev/c7a7d9ff99da

Comment 7 Ginn Chen 2011-09-16 09:28:32 PDT

http://hg.mozilla.org/mozilla-central/rev/c7a7d9ff99da