Closed
Bug 673854
Opened 14 years ago
Closed 14 years ago
(TypeInference)Fix TI for Solaris x86
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
(Whiteboard: fixed-in-jaegermonkey)
Attachments
(2 files)
|
11.71 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
|
11.24 KB,
patch
|
Details | Diff | Splinter Review |
Update TrampolineSUNWX86.s and TrampolineSUNWX64.s, also deal with no fastcall situation with Solaris Studio on x86.
The Solaris x64 version is blindly updated since JS/Solaris x64 is blocked by another issue.
Assignee: general → ginn.chen
Status: NEW → ASSIGNED
Attachment #548111 -
Flags: review?(bhackett1024)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 548111 [details] [diff] [review]
patch
Review of attachment 548111 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsinfer.cpp
@@ +72,5 @@
> #endif
>
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif
Why is this necessary? Is there a better place to do this include?
::: js/src/jsobj.cpp
@@ +109,5 @@
> #include "jsautooplen.h"
>
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif
Ditto.
Attachment #548111 -
Flags: review?(bhackett1024) → review+
<alloca.h> is required for alloca() with Solaris Studio compiler.
alloca() is used in DEBUG section in jsinfer.cpp.
alloca() is not used in jsobj.cpp now, so these lines are no longer needed for jsobj.cpp.
Looks like I have no write permission to any repo now, filed Bug 674451.
Whiteboard: fixed-in-jaegermonkey
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•