673854 - (TypeInference)Fix TI for Solaris x86

Status: RESOLVED FIXED

Description

[Ginn Chen]

Update TrampolineSUNWX86.s and TrampolineSUNWX64.s, also deal with no fastcall situation with Solaris Studio on x86.

Comment 1

[Ginn Chen]

Created attachment 548111 [details] [diff] [review]
patch

The Solaris x64 version is blindly updated since JS/Solaris x64 is blocked by another issue.

Comment 2

[Brian Hackett (:bhackett)]

Comment on attachment 548111 [details] [diff] [review]
patch

Review of attachment 548111 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinfer.cpp
@@ +72,5 @@
>  #endif
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Why is this necessary?  Is there a better place to do this include?

::: js/src/jsobj.cpp
@@ +109,5 @@
>  #include "jsautooplen.h"
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Ditto.

Comment 3

[Ginn Chen]

<alloca.h> is required for alloca() with Solaris Studio compiler.
alloca() is used in DEBUG section in jsinfer.cpp.

alloca() is not used in jsobj.cpp now, so these lines are no longer needed for jsobj.cpp.

Comment 4

[Ginn Chen]

Created attachment 548666 [details] [diff] [review]
patch to commit

I've no permission to jaegermonkey.

Comment 5

[Ginn Chen]

Looks like I have no write permission to any repo now, filed Bug 674451.

Comment 6

[Leon Sha]

http://hg.mozilla.org/projects/jaegermonkey/rev/c7a7d9ff99da

Comment 7

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/c7a7d9ff99da