(TypeInference)Fix TI for Solaris x86

RESOLVED FIXED

Status

()

Product:
Core
Component:
JavaScript Engine
Type:
defect
Status:
RESOLVED FIXED
Opened:
8 years ago
Updated:
8 years ago

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-jaegermonkey)

Attachments

(2 attachments)

patch
11.71 KB, patch
bhackett
: review+
Details | Diff | Splinter Review
patch to commit
11.24 KB, patch
Details | Diff | Splinter Review 
Update TrampolineSUNWX86.s and TrampolineSUNWX64.s, also deal with no fastcall situation with Solaris Studio on x86.
Posted patch patch — — Splinter Review 
The Solaris x64 version is blindly updated since JS/Solaris x64 is blocked by another issue.
Assignee: general → ginn.chen
Status: NEW → ASSIGNED
Attachment #548111 - Flags: review?(bhackett1024)
Comment on attachment 548111 [details] [diff] [review]
patch

Review of attachment 548111 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinfer.cpp
@@ +72,5 @@
>  #endif
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Why is this necessary?  Is there a better place to do this include?

::: js/src/jsobj.cpp
@@ +109,5 @@
>  #include "jsautooplen.h"
>  
> +#ifdef __SUNPRO_CC
> +#include <alloca.h>
> +#endif

Ditto.
Attachment #548111 - Flags: review?(bhackett1024) → review+
<alloca.h> is required for alloca() with Solaris Studio compiler.
alloca() is used in DEBUG section in jsinfer.cpp.

alloca() is not used in jsobj.cpp now, so these lines are no longer needed for jsobj.cpp.
I've no permission to jaegermonkey.
Looks like I have no write permission to any repo now, filed Bug 674451.
http://hg.mozilla.org/mozilla-central/rev/c7a7d9ff99da
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.