673890 - Deleting a bookmark does not remove it

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Anna (Waverley)]

I observed this issue first on fennec 6.0b2: 
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:6.0) Gecko/20110613 Firefox/6.0 Fennec/6.0 

Device: HTC Desire Z (Android 2.2)

Now I have seen it on Aurora too. 

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a2) Gecko/20110724 Firefox/7.0a2 Fennec/7.0a2

Device: Motorola Droid 2 (Android 2.2)

This is not reproducible and I don't have the exact steps to reproduce.
So far this is what I remembered doing (on both cases): I bookmarked and tagged two pages: cnn.com and google.com. I cleared the browsing history after which I did a new history. In this moment I tried to delete the bookmarked webpage cnn.com. The star still remained yellow. In the bookmarks tab there is no cnn.com, but in the All Pages tab you can see the webpage cnn starred and the name of the tag. Please see the video: http://www.youtube.com/user/qaioana#p/u/0/0RLboe1vXGY  (for 6.0b2)

Unfortunately I don't have the logs, but I will pay attention from now on to this issue.

Comment 1

[Andreea Pod]

Attachment: log

I can see this problem if I bookmark and add tag to a page. After I do some browsing I am not able to remove the bookmark and the Edit bookmark button is not working either. This happened in about an hour time interval, you can see the log attached.

Comment 2

[Anna (Waverley)]

I could also reproduce this issue. I have attached my log too. 

Note: This happens only for bookmarked pages that have tags. I tried reproducing this issue for a bookmarked page without tags and it works fine.

Comment 3

[Anna (Waverley)]

Attachment: log for motorola droid 2

Comment 4

[Aaron Train [:aaronmt]]

Doesn't look like there's much in those logs, anything in error console?

Comment 5

[Anna (Waverley)]

I can only see this error in the error console:

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIPropertyBag2.getProperty]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: jar:file:///data/app/org.mozilla.fennec_aurora-1.apk!/components/nsPlacesExpiration.js :: PEX__loadPrefs :: line 750"  data: no]
jar:file:///data/app/org.mozilla.fennec_aurora-1.apk!/components/nsPlacesExpiration.js
750

But there is already a bug filed. bug 661814. This issue happens pretty much actually.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Anna, Andreea, do you have Sync turned on/Synced?

Comment 7

[Andreea Pod]

Naoki we are able to reproduce it without having sync turned on.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Does the bug in comment 5 happen even when you can delete bookmarks?

or does deleting bookmarks fail anytime you see that error?

I'm tying to figure out if the error, which happens during startup, is causing something in the places system to not get initialized correctly, and therefore, causes bookmarks to not get deleted.

You can add bookmarks OK, right? Just deleting is broken?

Comment 9

[Anna (Waverley)]

Mark, that error appears only on startup.

This is what I did:

1. I cleared the application's profile (from Application -> manage Application -> Aurora -> Clear data)
2. I launch Aurora.
3. Enable the error console
4. Quit the application
5. Re-launch the application
6. Check the error console

So, I did no browsing, no bookmarks and the error is there. 

Yes, I can add bookmarks just fine. And I can delete them too if the deleting is made more or less after the bookmarking is done.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

That's interesting; in the video, I just noticed that the Cnn website was in the AllPages, but not in the bookmark section.  It's also starred in the content...

The closest I came is:
1) go to a web page; set a tag to it and a bookmark
2) in the awesome page, create a new tab with the bookmark
3) remove bookmark tab
4) hit the back button to close the tab
5) go back to the awesome pages and look at the all pages

Expected: the bookmark star and tag should be removed
Actual: the bookmark star and tag remain

Note:
1. if you refresh by going to the bookmarks and then the all pages with the steps that I have, it will remove the star and tag

Could it be something with opening the website through the new tab context menu?

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Can we get more people to try to reproduce this issue? Is it a phone issue? Can we get a regression range?

Comment 12

[Anna (Waverley)]

I don't think it's a phone issue, since it happens on HTC Desire Z (Android 2.2.1), LG Optimus 2X (Android 2.2.2) and Motorola Droid 2 (2.2). 

I could reproduce this issue on:
Mozilla /5.0 (Android;Linux armv7l;rv:8.0a1) Gecko/20110727 Firefox/8.0a1 Fennec/8.0a1  

only by bookmarking and tagging a webpage and not doing any other browsing history, just waiting for about half an hour and then trying to delete the bookmarked page.

I am trying right now to get a regression range.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Can you reproduce this?

Comment 14

[Anna (Waverley)]

I can still reproduce this on fennec 6 beta 6. 

Mozilla /5.0 (Android;Linux armv7l;rv:6.0) Gecko/20110810 Firefox/6.0 Fennec/6.0

I was trying to get a regression range, but if on some builds I could not reproduce it, I could reproduce it on previous builds to those that it wasn't reproducing. I don't think it has something to do with the browsing history, but with the time interval between when the bookmark is made and when the user wants to erase it. So maybe that's why I cannot always reproduce it. On some builds,  I don't wait long enough before actually erase the bookmark. I said on "some builds" because I also encountered builds on which after just 20 minutes I could not erase the bookmark.

Comment 15

[Martijn Wargers (dead)]

Can you still reproduce in the latest XUL build?
http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/10.0b6-candidates/build1/android/multi/

Comment 16

[BMO Automation]

Closing all opened bug in a graveyard component

Comment 17

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.

Comment 18

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.

Comment 19

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.