Comment 1 Mike Hommey [:glandium] 2011-07-25 12:27:56 PDT

We probably don't even build with a gcc that doesn't have the gcc3 ABI.

Comment 2 Felix Fung (:felix) 2011-09-27 21:48:24 PDT

Created attachment 562969 [details] [diff] [review]
Remove Checks for HAVE_GCC3_ABI

Removed all uses and checks for HAVE_GCC3_ABI and assumed it to be true throughout.

Comment 3 Mike Hommey [:glandium] 2011-09-28 07:58:34 PDT

Comment on attachment 562969 [details] [diff] [review]
Remove Checks for HAVE_GCC3_ABI

Review of attachment 562969 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/reflect/xptcall/src/md/unix/Makefile.in
@@ -371,3 @@
>  ASFILES		:= xptcinvoke_asm_sparc_linux_GCC3.s xptcstubs_asm_sparc_solaris.s
> -else
> -ASFILES		:= xptcinvoke_asm_sparc_linux.s xptcstubs_asm_sparc_solaris.s

Please remove the file that are not used anymore.

@@ -412,3 @@
>  ASFILES		:= xptcinvoke_asm_sparc_solaris_GCC3.s xptcstubs_asm_sparc_solaris.s
>  else
> -ASFILES		:= xptcinvoke_asm_sparc_solaris_GCC.s xptcstubs_asm_sparc_solaris.s

Likewise.

Comment 4 Felix Fung (:felix) 2011-09-28 14:00:00 PDT

Created attachment 563170 [details] [diff] [review]
Remove Checks for HAVE_GCC3_ABI

Removed xptcinvoke_asm_sparc_linux.s and xptcinvoke_asm_sparc_solaris_GCC.s

Comment 5 Dão Gottwald [:dao] 2011-09-29 06:30:03 PDT

http://hg.mozilla.org/integration/mozilla-inbound/rev/934fd93abd86

Comment 6 :Ehsan Akhgari 2011-09-29 14:30:28 PDT

https://hg.mozilla.org/mozilla-central/rev/47f550b4ef47

I accidentally pushed this patch to mozilla-central while it was living on inbound.  On the next merge, it will be merged.  Sorry for the mess!

Comment 7 :Ehsan Akhgari 2011-09-29 15:49:42 PDT

Merged from inbound: https://hg.mozilla.org/mozilla-central/rev/934fd93abd86