Status
People
(Reporter: glandium, Assigned: felix)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [good first bug], URL)
Attachments
(1 attachment, 1 obsolete attachment)
|
18.95 KB,
patch
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Reporter) | |
Comment 1•7 years ago
|
||
We probably don't even build with a gcc that doesn't have the gcc3 ABI.
Summary: Remove "check for gcc 3.0 ABI → Remove "check for gcc 3.0 ABI"
|
|
(Reporter) | |
Updated•7 years ago
|
||
Whiteboard: [good first bug]
|
||
Updated•7 years ago
|
||
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 562969 [details] [diff] [review] Remove Checks for HAVE_GCC3_ABI Removed all uses and checks for HAVE_GCC3_ABI and assumed it to be true throughout.
|
|
(Reporter) | |
Comment 3•7 years ago
|
||
Comment on attachment 562969 [details] [diff] [review] Remove Checks for HAVE_GCC3_ABI Review of attachment 562969 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/reflect/xptcall/src/md/unix/Makefile.in @@ -371,3 @@ > ASFILES := xptcinvoke_asm_sparc_linux_GCC3.s xptcstubs_asm_sparc_solaris.s > -else > -ASFILES := xptcinvoke_asm_sparc_linux.s xptcstubs_asm_sparc_solaris.s Please remove the file that are not used anymore. @@ -412,3 @@ > ASFILES := xptcinvoke_asm_sparc_solaris_GCC3.s xptcstubs_asm_sparc_solaris.s > else > -ASFILES := xptcinvoke_asm_sparc_solaris_GCC.s xptcstubs_asm_sparc_solaris.s Likewise.
Attachment #562969 -
Flags: review?(mh+mozilla) → review+
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Created attachment 563170 [details] [diff] [review] Remove Checks for HAVE_GCC3_ABI Removed xptcinvoke_asm_sparc_linux.s and xptcinvoke_asm_sparc_solaris_GCC.s
Attachment #562969 -
Attachment is obsolete: true
|
|
(Assignee) | |
Updated•7 years ago
|
||
Whiteboard: [good first bug] → checkin-needed
|
|
||
Updated•7 years ago
|
||
Keywords: checkin-needed
Whiteboard: checkin-needed
|
||
Comment 5•7 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/934fd93abd86
Keywords: checkin-needed
Whiteboard: [good first bug]
Target Milestone: --- → mozilla10
|
||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47f550b4ef47 I accidentally pushed this patch to mozilla-central while it was living on inbound. On the next merge, it will be merged. Sorry for the mess!
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•7 years ago
|
||
Merged from inbound: https://hg.mozilla.org/mozilla-central/rev/934fd93abd86
|
||
Updated•9 months ago
|
||
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.