Closed Bug 674012 Opened 14 years ago Closed 14 years ago

Remove "check for gcc 3.0 ABI"

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: glandium, Assigned: felix)

References

()

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 1 obsolete file)

No description provided.
We probably don't even build with a gcc that doesn't have the gcc3 ABI.
Summary: Remove "check for gcc 3.0 ABI → Remove "check for gcc 3.0 ABI"
Whiteboard: [good first bug]
Attached patch Remove Checks for HAVE_GCC3_ABI (obsolete) — Splinter Review
Removed all uses and checks for HAVE_GCC3_ABI and assumed it to be true throughout.
Assignee: nobody → ffung
Status: NEW → ASSIGNED
Attachment #562969 - Flags: review?(mh+mozilla)
Comment on attachment 562969 [details] [diff] [review] Remove Checks for HAVE_GCC3_ABI Review of attachment 562969 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/reflect/xptcall/src/md/unix/Makefile.in @@ -371,3 @@ > ASFILES := xptcinvoke_asm_sparc_linux_GCC3.s xptcstubs_asm_sparc_solaris.s > -else > -ASFILES := xptcinvoke_asm_sparc_linux.s xptcstubs_asm_sparc_solaris.s Please remove the file that are not used anymore. @@ -412,3 @@ > ASFILES := xptcinvoke_asm_sparc_solaris_GCC3.s xptcstubs_asm_sparc_solaris.s > else > -ASFILES := xptcinvoke_asm_sparc_solaris_GCC.s xptcstubs_asm_sparc_solaris.s Likewise.
Attachment #562969 - Flags: review?(mh+mozilla) → review+
Removed xptcinvoke_asm_sparc_linux.s and xptcinvoke_asm_sparc_solaris_GCC.s
Attachment #562969 - Attachment is obsolete: true
Whiteboard: [good first bug] → checkin-needed
Keywords: checkin-needed
Whiteboard: checkin-needed
Keywords: checkin-needed
Whiteboard: [good first bug]
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/47f550b4ef47 I accidentally pushed this patch to mozilla-central while it was living on inbound. On the next merge, it will be merged. Sorry for the mess!
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: