Closed Bug 674161 Opened 9 years ago Closed 9 years ago

Middle mouse paste is not subject to the javascript: URL security changes in bug 656433 (current page's principal shouldn't be inherited)

Categories

(Firefox :: General, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 10

People

(Reporter: jruderman, Assigned: Gavin)

References

(Blocks 2 open bugs)

Details

(Keywords: csectype-spoof, sec-low)

Attachments

(1 file, 2 obsolete files)

(Split from bug 405620 -- originally reported by georgi)

1. Select the text 
      javascript:alert(document.cookie)
2. Middle-click a blank area of another web page

Result: XSS!!1

Combined with bug 405620, this is perhaps a little worse than the other javascript: URL bugs. But it only affects Linux users.
Attached patch WIP (obsolete) — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Duplicate of this bug: 686484
Summary: Middle mouse paste is not subject to the javascript: URL security changes in bug 656433 → Middle mouse paste is not subject to the javascript: URL security changes in bug 656433 (current page's principal shouldn't be inherited)
What solution will be made and in what version of FF?
By the way: it  also affects addons which loads external content like RSS readers.
In such case evil code will be executed in chrome:// zone.
Duplicate of this bug: 692060
Attached patch patch (obsolete) — Splinter Review
It would be cleaner to make disallowing the principal inheritance openUILinkIn's default behavior, but that has the potential to break people, given its wide use. Maybe we can revisit that separately.
Attachment #548814 - Attachment is obsolete: true
Attachment #564925 - Flags: review?(dao)
This patch is on top of the patch for bug 610203.
Depends on: 610203
Comment on attachment 564925 [details] [diff] [review]
patch

When you enter a new url in the urlbar in an app tab, it does open in a new tab like we want in bug 598587, but the urlbar value in the app tab doesn't revert like it should.

Additionally, openLinkIn doesn't do a host comparison before deciding to open the url in a new tab, which is part of what bug 598587 requires (however I think this is less of a big deal and could be done in a follow-up bug).
Attachment #564925 - Flags: feedback-
Attachment #564925 - Flags: review?(dao)
Attached patch patchSplinter Review
Good catch!

The URL bar changes really aren't relevant to this bug, I shouldn't have included them here. Here's a patch that just fixes this as summarized (which still includes the changes to openLinkIn).
Attachment #567254 - Flags: review?(dao)
No longer blocks: 598587
Attachment #564925 - Attachment is obsolete: true
Attachment #567254 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9252c9e484fc
Flags: in-testsuite+
Hardware: x86_64 → All
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/9252c9e484fc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Keywords: csec-spoof, sec-low
Whiteboard: [sg:low]
You need to log in before you can comment on or make changes to this bug.