674164 - [jsdbg2] Make onNewScript consistent for cached eval scripts

Status: NEW

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

The invariant I want to establish is: if your onNewScript handler walks the getChildScripts tree, and it gets in before any JS code, it will see every single Debugger.Script object you ever find on the stack. 

Currently I think you get a new Debugger.Script each time a cached eval script is used, but only the first one is delivered to onNewScript. Two possible paths:

  - use the same Debugger.Script every time for a cached eval script
    (but this would mean if we cleared out the cache, the Debugger.Script might
    become dead, or else it would have to keep the JSScript alive)

  - fire the onNewScript hook each time the cached script is used
    (but that means multiple Debug.Scripts could have the same child scripts,
    i.e. the getChildScripts graph is not a collection of trees but a
    collection of dags)

Comment 1

[Jason Orendorff [:jorendorff]]

I think the patches in bug 665167 fix this, but I need to add a test for it. Taking.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: tests

Yep. With the patches in bug 665167 applied, these tests pass.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.